Page MenuHomePhabricator

In JSON DocumentEngine, preserve the distinction between "{}" and "[]"
ClosedPublic

Authored by epriestley on Mar 11 2021, 8:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 7:15 AM
Unknown Object (File)
Thu, Dec 5, 11:22 AM
Unknown Object (File)
Nov 26 2024, 3:09 AM
Unknown Object (File)
Nov 23 2024, 2:57 AM
Unknown Object (File)
Nov 14 2024, 1:53 PM
Unknown Object (File)
Nov 4 2024, 7:20 AM
Unknown Object (File)
Oct 1 2024, 8:30 AM
Unknown Object (File)
Oct 1 2024, 6:15 AM
Subscribers
None

Details

Summary

Ref T13635. Currently, the JSON DocumentEngine uses "phutil_json_decode()", but this can confuse "{}" and "[]".

Be more careful about how the JSON value is decoded, to preserve the distinction.

Test Plan

Screen Shot 2021-03-11 at 11.52.09 AM.png (201×790 px, 70 KB)

Diff Detail

Repository
rP Phabricator
Branch
json2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25239
Build 34834: Run Core Tests
Build 34833: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 11 2021, 8:50 PM
This revision was automatically updated to reflect the committed changes.