Page MenuHomePhabricator

In JSON DocumentEngine, preserve the distinction between "{}" and "[]"
ClosedPublic

Authored by epriestley on Mar 11 2021, 8:43 PM.
Tags
None
Referenced Files
F15543074: D21605.id51432.diff
Fri, Apr 25, 8:29 PM
F15542474: D21605.id.diff
Fri, Apr 25, 4:50 PM
F15538862: D21605.diff
Thu, Apr 24, 9:57 PM
F15510858: D21605.diff
Wed, Apr 16, 9:33 PM
F15502653: D21605.id51434.diff
Mon, Apr 14, 2:54 AM
F15480997: D21605.id51434.diff
Tue, Apr 8, 5:43 PM
F15477209: D21605.id51432.diff
Mon, Apr 7, 12:58 PM
F15433710: D21605.diff
Mar 25 2025, 12:20 AM
Subscribers
None

Details

Summary

Ref T13635. Currently, the JSON DocumentEngine uses "phutil_json_decode()", but this can confuse "{}" and "[]".

Be more careful about how the JSON value is decoded, to preserve the distinction.

Test Plan

Screen Shot 2021-03-11 at 11.52.09 AM.png (201×790 px, 70 KB)

Diff Detail

Repository
rP Phabricator
Branch
json2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25239
Build 34834: Run Core Tests
Build 34833: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 11 2021, 8:50 PM
This revision was automatically updated to reflect the committed changes.