Page MenuHomePhabricator

In JSON DocumentEngine, preserve the distinction between "{}" and "[]"
ClosedPublic

Authored by epriestley on Mar 11 2021, 8:43 PM.
Tags
None
Referenced Files
F15433710: D21605.diff
Tue, Mar 25, 12:20 AM
F15379048: D21605.id51434.diff
Thu, Mar 13, 6:22 PM
F15308139: D21605.diff
Mar 6 2025, 5:56 AM
F15285237: D21605.diff
Mar 4 2025, 12:15 PM
Unknown Object (File)
Mar 3 2025, 4:47 PM
Unknown Object (File)
Feb 21 2025, 1:31 PM
Unknown Object (File)
Feb 19 2025, 7:42 PM
Unknown Object (File)
Feb 9 2025, 10:09 AM
Subscribers
None

Details

Summary

Ref T13635. Currently, the JSON DocumentEngine uses "phutil_json_decode()", but this can confuse "{}" and "[]".

Be more careful about how the JSON value is decoded, to preserve the distinction.

Test Plan

Screen Shot 2021-03-11 at 11.52.09 AM.png (201×790 px, 70 KB)

Diff Detail

Repository
rP Phabricator
Branch
json2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25239
Build 34834: Run Core Tests
Build 34833: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 11 2021, 8:50 PM
This revision was automatically updated to reflect the committed changes.