Page MenuHomePhabricator
Differential D21605

In JSON DocumentEngine, preserve the distinction between "{}" and "[]"
ClosedPublic
Actions

Authored by epriestley on Mar 11 2021, 8:43 PM.
Tags
None
Referenced Files
F18602108: D21605.diff
Sat, Sep 13, 2:17 PM
F18594090: D21605.id.diff
Fri, Sep 12, 4:57 PM
F18587883: D21605.diff
Thu, Sep 11, 10:41 PM
F18571760: D21605.id51434.diff
Wed, Sep 10, 5:21 AM
F18571757: D21605.id51432.diff
Wed, Sep 10, 5:21 AM
F18432219: D21605.diff
Sun, Aug 31, 6:20 AM
F18098067: D21605.id.diff
Aug 8 2025, 6:16 PM
F18095461: D21605.diff
Aug 7 2025, 11:49 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13635: JSON DocumentEngine may confuse "{}" and "[]"
Commits
rP4484946cfd29: In JSON DocumentEngine, preserve the distinction between "{}" and "[]"
Summary

Ref T13635. Currently, the JSON DocumentEngine uses "phutil_json_decode()", but this can confuse "{}" and "[]".

Be more careful about how the JSON value is decoded, to preserve the distinction.

Test Plan

Screen Shot 2021-03-11 at 11.52.09 AM.png (201×790 px, 70 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 11 2021, 8:43 PM
Harbormaster completed remote builds in B25239: Diff 51432.Mar 11 2021, 8:44 PM
epriestley requested review of this revision.Mar 11 2021, 8:44 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 11 2021, 8:50 PM
Closed by commit rP4484946cfd29: In JSON DocumentEngine, preserve the distinction between "{}" and "[]" (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP4484946cfd29: In JSON DocumentEngine, preserve the distinction between "{}" and "[]".

Revision Contents
Changeset List

Diff 51434

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/files/document/PhabricatorJSONDocumentEngine.php

Loading...
View Options

src/applications/files/document/exception/PhabricatorDocumentEngineParserException.php

Loading...
Phabricator · Built by Phacility