Page MenuHomePhabricator

In JSON DocumentEngine, preserve the distinction between "{}" and "[]"
ClosedPublic

Authored by epriestley on Mar 11 2021, 8:43 PM.
Tags
None
Referenced Files
F18098067: D21605.id.diff
Fri, Aug 8, 6:16 PM
F18095461: D21605.diff
Thu, Aug 7, 11:49 PM
F17885757: D21605.id51432.diff
Jul 29 2025, 12:31 AM
F17865316: D21605.id51434.diff
Jul 28 2025, 3:11 AM
F17847335: D21605.diff
Jul 27 2025, 6:02 AM
F17756266: D21605.id51434.diff
Jul 22 2025, 1:53 PM
F17756265: D21605.id51432.diff
Jul 22 2025, 1:53 PM
F17756039: D21605.id.diff
Jul 22 2025, 1:33 PM
Subscribers
None

Details

Summary

Ref T13635. Currently, the JSON DocumentEngine uses "phutil_json_decode()", but this can confuse "{}" and "[]".

Be more careful about how the JSON value is decoded, to preserve the distinction.

Test Plan

Screen Shot 2021-03-11 at 11.52.09 AM.png (201×790 px, 70 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 11 2021, 8:50 PM
This revision was automatically updated to reflect the committed changes.