Page MenuHomePhabricator

In JSON DocumentEngine, preserve the distinction between "{}" and "[]"
ClosedPublic

Authored by epriestley on Mar 11 2021, 8:43 PM.
Tags
None
Referenced Files
F18783705: D21605.id51432.diff
Mon, Oct 13, 8:59 AM
F18783444: D21605.id51432.diff
Mon, Oct 13, 6:45 AM
F18734409: D21605.diff
Tue, Sep 30, 10:53 PM
F18602108: D21605.diff
Sep 13 2025, 2:17 PM
F18594090: D21605.id.diff
Sep 12 2025, 4:57 PM
F18587883: D21605.diff
Sep 11 2025, 10:41 PM
F18571760: D21605.id51434.diff
Sep 10 2025, 5:21 AM
F18571757: D21605.id51432.diff
Sep 10 2025, 5:21 AM
Subscribers
None

Details

Summary

Ref T13635. Currently, the JSON DocumentEngine uses "phutil_json_decode()", but this can confuse "{}" and "[]".

Be more careful about how the JSON value is decoded, to preserve the distinction.

Test Plan

Screen Shot 2021-03-11 at 11.52.09 AM.png (201×790 px, 70 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 11 2021, 8:50 PM
This revision was automatically updated to reflect the committed changes.