Page MenuHomePhabricator

In JSON DocumentEngine, preserve the distinction between "{}" and "[]"
ClosedPublic

Authored by epriestley on Mar 11 2021, 8:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 20, 1:36 AM
Unknown Object (File)
Tue, Mar 5, 2:32 AM
Unknown Object (File)
Feb 8 2024, 3:17 PM
Unknown Object (File)
Jan 31 2024, 10:30 AM
Unknown Object (File)
Jan 30 2024, 7:14 PM
Unknown Object (File)
Jan 30 2024, 7:08 PM
Unknown Object (File)
Jan 21 2024, 4:43 PM
Unknown Object (File)
Jan 17 2024, 4:30 PM
Subscribers
None

Details

Summary

Ref T13635. Currently, the JSON DocumentEngine uses "phutil_json_decode()", but this can confuse "{}" and "[]".

Be more careful about how the JSON value is decoded, to preserve the distinction.

Test Plan

Screen Shot 2021-03-11 at 11.52.09 AM.png (201×790 px, 70 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 11 2021, 8:50 PM
This revision was automatically updated to reflect the committed changes.