Page MenuHomePhabricator
Differential D21584

Prevent external connections from being mutated on held locks
ClosedPublic
Actions

Authored by epriestley on Mar 2 2021, 8:56 PM.
Tags
None
Referenced Files
F14957929: D21584.diff
Sun, Feb 16, 3:48 AM
F14957174: D21584.diff
Sun, Feb 16, 3:05 AM
Unknown Object (File)
Sun, Feb 9, 10:06 AM
Unknown Object (File)
Sun, Feb 9, 10:05 AM
Unknown Object (File)
Sun, Feb 9, 10:05 AM
Unknown Object (File)
Sat, Jan 25, 9:13 AM
Unknown Object (File)
Sat, Jan 25, 9:13 AM
Unknown Object (File)
Sat, Jan 25, 9:13 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13627: Until MySQL 5.7, each MySQL connection may hold only one simultaneous lock
Commits
rP84049ed4793c: (stable) Prevent external connections from being mutated on held locks
rP466013f11a6d: Prevent external connections from being mutated on held locks
Summary

Ref T13627. This makes the API harder to misuse: setting an external connection on a held lock isn't a meaningful operation. Prevent it.

Test Plan

Added a failing test, made it pass.

Diff Detail

Repository
rP Phabricator
Branch
lock2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25189
Build 34763: Run Core Tests
Build 34762: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
protocol/
2 lines
infrastructure/
storage/
management/
workflow/
2 lines
util/
15 lines
__tests__/
26 lines

Diff 51381

View Options

src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php

Loading...
View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php

Loading...
View Options

src/infrastructure/util/PhabricatorGlobalLock.php

Loading...
View Options

src/infrastructure/util/__tests__/PhabricatorGlobalLockTestCase.php

Loading...
Phabricator · Built by Phacility