Prevent external connections from being mutated on held locks
ClosedPublic
Actions

Authored by epriestley on Mar 2 2021, 8:56 PM.

Details

Reviewers: None
Maniphest Tasks: T13627: Until MySQL 5.7, each MySQL connection may hold only one simultaneous lock
Commits: rP84049ed4793c: (stable) Prevent external connections from being mutated on held locks
rP466013f11a6d: Prevent external connections from being mutated on held locks

Summary

Ref T13627. This makes the API harder to misuse: setting an external connection on a held lock isn't a meaningful operation. Prevent it.

Test Plan

Added a failing test, made it pass.

Diff Detail

Repository

rP Phabricator

Branch

lock2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25189
Build 34763: Run Core Tests
Build 34762: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 2 2021, 8:56 PM

Harbormaster completed remote builds in B25189: Diff 51381.Mar 2 2021, 8:57 PM

epriestley requested review of this revision.Mar 2 2021, 8:57 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 2 2021, 9:44 PM

Closed by commit rP466013f11a6d: Prevent external connections from being mutated on held locks (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP466013f11a6d: Prevent external connections from being mutated on held locks.

epriestley added a commit: rP84049ed4793c: (stable) Prevent external connections from being mutated on held locks.Mar 3 2021, 3:26 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

protocol/

DiffusionRepositoryClusterEngine.php

2 lines

infrastructure/

storage/

management/

workflow/

PhabricatorStorageManagementWorkflow.php

2 lines

util/

PhabricatorGlobalLock.php

15 lines

__tests__/

PhabricatorGlobalLockTestCase.php

26 lines

Diff 51381

View Options

src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php

View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php

View Options

src/infrastructure/util/PhabricatorGlobalLock.php

View Options

src/infrastructure/util/tests/PhabricatorGlobalLockTestCase.php

Prevent external connections from being mutated on held locksClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 51381

src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php

src/infrastructure/util/PhabricatorGlobalLock.php

src/infrastructure/util/__tests__/PhabricatorGlobalLockTestCase.php

Prevent external connections from being mutated on held locks
ClosedPublic
Actions

Revision Contents
Changeset List

src/infrastructure/util/tests/PhabricatorGlobalLockTestCase.php