Page MenuHomePhabricator
Differential D21564

Lift core of "HeraldConditionResult" to "HeraldTranscriptResult"
ClosedPublic
Actions

Authored by epriestley on Feb 18 2021, 5:42 PM.
Tags
None
Referenced Files
F15462830: D21564.id51352.diff
Tue, Apr 1, 5:57 PM
F15443529: D21564.id.diff
Thu, Mar 27, 4:52 AM
F15440319: D21564.diff
Wed, Mar 26, 12:05 PM
F15436821: D21564.diff
Tue, Mar 25, 4:37 PM
F15381235: D21564.diff
Fri, Mar 14, 6:36 AM
F15379765: D21564.diff
Thu, Mar 13, 11:16 PM
Unknown Object (File)
Feb 25 2025, 4:58 AM
Unknown Object (File)
Feb 24 2025, 4:29 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13586: In Herald transcripts, surface exceptions encountered while evaluating fields
Commits
rPb047653e536e: Lift core of "HeraldConditionResult" to "HeraldTranscriptResult"
Summary

Ref T13586. Lift the behavioral core of "HeraldConditionResult" into a new abstract base "HeraldTranscriptResult", with the intent to introduce a "HeraldRuleResult".

Test Plan
  • Ran Herald rules, reviewed transcripts.
  • This change should have no behavioral effect.

Diff Detail

Repository
rP Phabricator
Branch
herald3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25144
Build 34701: Run Core Tests
Build 34700: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 18 2021, 5:42 PM
Harbormaster completed remote builds in B25144: Diff 51335.Feb 18 2021, 5:43 PM
epriestley requested review of this revision.Feb 18 2021, 5:43 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 19 2021, 7:16 PM
Closed by commit rPb047653e536e: Lift core of "HeraldConditionResult" to "HeraldTranscriptResult" (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPb047653e536e: Lift core of "HeraldConditionResult" to "HeraldTranscriptResult".

Revision Contents
Changeset List

PathSize
src/
applications/
herald/
storage/
transcript/
81 lines
4 lines
82 lines

Diff 51335

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/herald/storage/transcript/HeraldConditionResult.php

Loading...
View Options

src/applications/herald/storage/transcript/HeraldConditionTranscript.php

Loading...
View Options

src/applications/herald/storage/transcript/HeraldTranscriptResult.php

Loading...
Phabricator · Built by Phacility