Page MenuHomePhabricator
Differential D21547

When a subscriber can't see an object, clearly show that they're missing the permission in the curtain UI
ClosedPublic
Actions

Authored by epriestley on Feb 5 2021, 4:06 PM.
Tags
None
Referenced Files
F15458076: D21547.id51290.diff
Sun, Mar 30, 8:39 PM
F15455916: D21547.id51312.diff
Sun, Mar 30, 5:41 AM
F15452396: D21547.id51290.diff
Sat, Mar 29, 4:28 AM
F15450058: D21547.id.diff
Fri, Mar 28, 1:38 PM
F15444267: D21547.diff
Thu, Mar 27, 8:46 AM
F15414447: D21547.diff
Thu, Mar 20, 12:38 AM
F15384324: D21547.diff
Fri, Mar 14, 7:31 PM
F15312030: D21547.diff
Thu, Mar 6, 1:14 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers
Commits
rPa4cb2bb77247: When a subscriber can't see an object, clearly show that they're missing the…
Summary

Ref T13602. When a subscriber can't see an object, it's currently hard to figure it out.

Show this status clearly in the curtain UI.

Test Plan

Screen Shot 2021-02-05 at 7.33.06 AM.png (233×331 px, 15 KB)

Diff Detail

Repository
rP Phabricator
Branch
policy2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25101
Build 34637: Run Core Tests
Build 34636: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 5 2021, 4:06 PM
Harbormaster completed remote builds in B25101: Diff 51290.Feb 5 2021, 4:08 PM
epriestley requested review of this revision.Feb 5 2021, 4:08 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2021, 9:37 PM
Closed by commit rPa4cb2bb77247: When a subscriber can't see an object, clearly show that they're missing the… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPa4cb2bb77247: When a subscriber can't see an object, clearly show that they're missing the….

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
applications/
phid/
63 lines
policy/
filter/
62 lines
subscriptions/
engineextension/
15 lines
view/
phui/
29 lines
webroot/
rsrc/
css/
phui/
13 lines

Diff 51290

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/phid/PhabricatorObjectHandle.php

Loading...
View Options

src/applications/policy/filter/PhabricatorPolicyFilterSet.php

Loading...
View Options

src/applications/subscriptions/engineextension/PhabricatorSubscriptionsCurtainExtension.php

Loading...
View Options

src/view/phui/PHUICurtainObjectRefView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-curtain-object-ref-view.css

Loading...
Phabricator · Built by Phacility