Page MenuHomePhabricator

Remove "AlmanacPropertyInterface" from "AlmanacNamespace"
ClosedPublic

Authored by epriestley on Feb 3 2021, 11:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 5 2024, 1:16 PM
Unknown Object (File)
Dec 27 2023, 1:41 PM
Unknown Object (File)
Dec 22 2023, 10:01 AM
Unknown Object (File)
Dec 22 2023, 3:29 AM
Unknown Object (File)
Nov 30 2023, 6:14 AM
Unknown Object (File)
Nov 19 2023, 7:54 AM
Unknown Object (File)
Oct 5 2023, 9:33 AM
Unknown Object (File)
Aug 7 2023, 12:06 AM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/i-cant-create-almanac-space/4424/.

Almanac namespaces have never really had property support, but they implemented the interface in the original implementation.

At the time, this had no effect. Later changes integrated properties into the edit flows and broke this no-op integration.

Remove the interface for now. They could be given property support later, but need a bit of support code.

This feature is very rarely used and primarily useful for Phacility instances.

Test Plan

Created new namespaces and edited namespaces, browsed namespace UI.

Diff Detail

Repository
rP Phabricator
Branch
namespace1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25093
Build 34626: Run Core Tests
Build 34625: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 3 2021, 11:20 PM
This revision was automatically updated to reflect the committed changes.