Page MenuHomePhabricator

Remove "AlmanacPropertyInterface" from "AlmanacNamespace"
ClosedPublic

Authored by epriestley on Wed, Feb 3, 11:04 PM.

Details

Summary

See https://discourse.phabricator-community.org/t/i-cant-create-almanac-space/4424/.

Almanac namespaces have never really had property support, but they implemented the interface in the original implementation.

At the time, this had no effect. Later changes integrated properties into the edit flows and broke this no-op integration.

Remove the interface for now. They could be given property support later, but need a bit of support code.

This feature is very rarely used and primarily useful for Phacility instances.

Test Plan

Created new namespaces and edited namespaces, browsed namespace UI.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Feb 3, 11:20 PM
This revision was automatically updated to reflect the committed changes.