Page MenuHomePhabricator

Remove "AlmanacPropertyInterface" from "AlmanacNamespace"
ClosedPublic

Authored by epriestley on Feb 3 2021, 11:04 PM.
Tags
None
Referenced Files
F15285534: D21543.diff
Tue, Mar 4, 2:21 PM
Unknown Object (File)
Wed, Feb 26, 7:36 AM
Unknown Object (File)
Wed, Feb 26, 7:32 AM
Unknown Object (File)
Feb 9 2025, 10:00 AM
Unknown Object (File)
Feb 9 2025, 10:00 AM
Unknown Object (File)
Feb 9 2025, 10:00 AM
Unknown Object (File)
Jan 25 2025, 8:59 AM
Unknown Object (File)
Jan 25 2025, 8:59 AM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/i-cant-create-almanac-space/4424/.

Almanac namespaces have never really had property support, but they implemented the interface in the original implementation.

At the time, this had no effect. Later changes integrated properties into the edit flows and broke this no-op integration.

Remove the interface for now. They could be given property support later, but need a bit of support code.

This feature is very rarely used and primarily useful for Phacility instances.

Test Plan

Created new namespaces and edited namespaces, browsed namespace UI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 3 2021, 11:20 PM
This revision was automatically updated to reflect the committed changes.