Page MenuHomePhabricator

Catch more HTTP VCS errors and convert them into VCS repsonses
ClosedPublic

Authored by epriestley on Jan 27 2021, 12:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 4, 5:59 PM
Unknown Object (File)
Wed, Jun 4, 8:30 AM
Unknown Object (File)
Apr 28 2025, 11:05 PM
Unknown Object (File)
Apr 18 2025, 11:43 PM
Unknown Object (File)
Mar 28 2025, 7:17 PM
Unknown Object (File)
Mar 28 2025, 9:28 AM
Unknown Object (File)
Mar 27 2025, 7:06 PM
Unknown Object (File)
Mar 26 2025, 4:28 PM
Subscribers
None

Details

Summary

Ref T13590. Currently, errors arising from cluster locking (like the "stuck write lock" exception) are not caught and converted into VCS responses on the HTTP VCS workflow.

Catch a broader range of exceptions and convert them into appropriate responses.

Test Plan
  • Forced a "stuck write lock" exception, pushed to a Git repository over HTTP.
  • Before: generic fatal.
  • After: VCS-specific fatal with a useful message in the "X-Phabricator-Message" response header.

Diff Detail

Repository
rP Phabricator
Branch
http3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25045
Build 34557: Run Core Tests
Build 34556: arc lint + arc unit