Page MenuHomePhabricator

Catch more HTTP VCS errors and convert them into VCS repsonses
ClosedPublic

Authored by epriestley on Jan 27 2021, 12:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 8, 2:20 PM
Unknown Object (File)
Thu, Nov 28, 12:05 AM
Unknown Object (File)
Sat, Nov 23, 9:20 PM
Unknown Object (File)
Sat, Nov 23, 7:49 PM
Unknown Object (File)
Oct 17 2024, 7:43 AM
Unknown Object (File)
Oct 1 2024, 7:08 PM
Unknown Object (File)
Oct 1 2024, 11:10 AM
Unknown Object (File)
Sep 28 2024, 2:53 AM
Subscribers
None

Details

Summary

Ref T13590. Currently, errors arising from cluster locking (like the "stuck write lock" exception) are not caught and converted into VCS responses on the HTTP VCS workflow.

Catch a broader range of exceptions and convert them into appropriate responses.

Test Plan
  • Forced a "stuck write lock" exception, pushed to a Git repository over HTTP.
  • Before: generic fatal.
  • After: VCS-specific fatal with a useful message in the "X-Phabricator-Message" response header.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable