Page MenuHomePhabricator

Catch more HTTP VCS errors and convert them into VCS repsonses
ClosedPublic

Authored by epriestley on Jan 27 2021, 12:03 AM.
Tags
None
Referenced Files
F18105884: D21525.id51232.diff
Sun, Aug 10, 8:17 PM
F18104229: D21525.id51234.diff
Sun, Aug 10, 10:47 AM
F18102126: D21525.id.diff
Sat, Aug 9, 6:25 PM
F18098013: D21525.diff
Fri, Aug 8, 5:48 PM
Unknown Object (File)
Jun 4 2025, 5:59 PM
Unknown Object (File)
Jun 4 2025, 8:30 AM
Unknown Object (File)
Apr 28 2025, 11:05 PM
Unknown Object (File)
Apr 18 2025, 11:43 PM
Subscribers
None

Details

Summary

Ref T13590. Currently, errors arising from cluster locking (like the "stuck write lock" exception) are not caught and converted into VCS responses on the HTTP VCS workflow.

Catch a broader range of exceptions and convert them into appropriate responses.

Test Plan
  • Forced a "stuck write lock" exception, pushed to a Git repository over HTTP.
  • Before: generic fatal.
  • After: VCS-specific fatal with a useful message in the "X-Phabricator-Message" response header.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable