Page MenuHomePhabricator

Catch more HTTP VCS errors and convert them into VCS repsonses
ClosedPublic

Authored by epriestley on Jan 27 2021, 12:03 AM.

Details

Summary

Ref T13590. Currently, errors arising from cluster locking (like the "stuck write lock" exception) are not caught and converted into VCS responses on the HTTP VCS workflow.

Catch a broader range of exceptions and convert them into appropriate responses.

Test Plan
  • Forced a "stuck write lock" exception, pushed to a Git repository over HTTP.
  • Before: generic fatal.
  • After: VCS-specific fatal with a useful message in the "X-Phabricator-Message" response header.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.