Page MenuHomePhabricator

After loading the effective Viewer during a VCS request, flag them for inline cache generation
ClosedPublic

Authored by epriestley on Jan 27 2021, 12:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 16 2024, 3:02 PM
Unknown Object (File)
Jan 11 2024, 10:25 AM
Unknown Object (File)
Dec 28 2023, 4:27 PM
Unknown Object (File)
Dec 27 2023, 1:40 PM
Unknown Object (File)
Dec 22 2023, 3:27 AM
Unknown Object (File)
Nov 30 2023, 5:14 AM
Unknown Object (File)
Nov 18 2023, 10:38 AM
Unknown Object (File)
Jun 23 2023, 9:05 AM
Subscribers
None

Details

Summary

Ref T13590. User objects have some inline caches that don't do readthrough generation by default because it may be indicative of high-impact performance problems in code.

During a VCS request, these caches are normally unnecessary, but they may be hit on some unusual pathways (like error handling).

Flag VCS users as okay for inline generation. This does not indicate a performance problem and access to these caches is very rare, at least today.

Test Plan
  • Executed a Git HTTP request which hit an unhandled exception (stuck write lock).
    • Before: got a second-level exception while handling the first exception, when trying to access user preferences to render a standard uncaught exception page.
    • After: no second-level exception.

Diff Detail

Repository
rP Phabricator
Branch
http2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25044
Build 34555: Run Core Tests
Build 34554: arc lint + arc unit