Page MenuHomePhabricator

After loading the effective Viewer during a VCS request, flag them for inline cache generation
ClosedPublic

Authored by epriestley on Jan 27 2021, 12:01 AM.

Details

Summary

Ref T13590. User objects have some inline caches that don't do readthrough generation by default because it may be indicative of high-impact performance problems in code.

During a VCS request, these caches are normally unnecessary, but they may be hit on some unusual pathways (like error handling).

Flag VCS users as okay for inline generation. This does not indicate a performance problem and access to these caches is very rare, at least today.

Test Plan
  • Executed a Git HTTP request which hit an unhandled exception (stuck write lock).
    • Before: got a second-level exception while handling the first exception, when trying to access user preferences to render a standard uncaught exception page.
    • After: no second-level exception.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.