Differential D21520

Fix a "setExternalURI()" fatal while browsing directories with submodules
ClosedPublic
Actions

Authored by epriestley on Jan 26 2021, 4:42 PM.

Details

Reviewers: None
Maniphest Tasks: T13595: Browsing directories with submodules fails with bad call to "setExternalURI()"
Commits: rP510bdc74dbc3: (stable) Fix a "setExternalURI()" fatal while browsing directories with…
rP888604c9dd01: Fix a "setExternalURI()" fatal while browsing directories with submodules

Summary

Ref T13595. See that task for discussion.

D21511 renamed the iteration variable here (previously "$path") but did not rename this use of it.

Test Plan

In Diffusion, browsed a directory with a submodule.
- Before: "setExternalURI()" fatal in conduit call.
- After: directory listing including submodule.

Diff Detail

Repository

rP Phabricator

Branch

submodule1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25035
Build 34542: Run Core Tests
Build 34541: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 26 2021, 4:42 PM

Harbormaster completed remote builds in B25035: Diff 51222.Jan 26 2021, 4:44 PM

epriestley requested review of this revision.Jan 26 2021, 4:44 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 26 2021, 5:14 PM

Closed by commit rP888604c9dd01: Fix a "setExternalURI()" fatal while browsing directories with submodules (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP888604c9dd01: Fix a "setExternalURI()" fatal while browsing directories with submodules.

epriestley added a commit: rP510bdc74dbc3: (stable) Fix a "setExternalURI()" fatal while browsing directories with….Jan 26 2021, 8:31 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

conduit/

DiffusionBrowseQueryConduitAPIMethod.php

2 lines

Diff 51222

View Options

src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php

Fix a "setExternalURI()" fatal while browsing directories with submodulesClosedPublicActions