Paths

Table of Contentst

Differential D21513

Correct the behavior of "bin/repository discover --repair"
ClosedPublic
Actions

Authored by epriestley on Jan 22 2021, 8:25 PM.

Tags

None

Referenced Files

	F13089335: D21513.diff
	Thu, Apr 25, 1:45 AM

	Unknown Object (File)
	Sat, Apr 20, 5:30 PM

	Unknown Object (File)
	Wed, Apr 17, 2:52 PM

	Unknown Object (File)
	Fri, Apr 5, 5:45 PM

	Unknown Object (File)
	Thu, Mar 28, 6:01 PM

	Unknown Object (File)
	Mar 26 2024, 4:54 AM

	Unknown Object (File)
	Jan 25 2024, 2:28 AM

	Unknown Object (File)
	Jan 7 2024, 4:42 AM

View All 48 Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13591: Importing repositories may incorrectly queue some tasks at "PRIORITY_COMMIT"
Commits: rP16a14af2bb17: Correct the behavior of "bin/repository discover --repair"

Summary

Ref T13591. Since D8781, this flag does not function correctly in Git and Mercurial repositories, since ref discovery pre-fills the cache.

Move the "don't look at the database" behavior the flag enables into the cache lookup. D8781 should have been slightly more aggressive and done this, it was just overlooked.

Test Plan

Ran bin/repository discover --help and read the updated help text.
Ran bin/repository discover --repair in a fully-discovered Git repository.
- Before: no effect.
- After: full rediscovery.

Diff Detail

Repository

Branch

repair1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25018
Build 34518: Run Core Tests
Build 34517: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 22 2021, 8:25 PM

Harbormaster completed remote builds in B25018: Diff 51207.Jan 22 2021, 8:26 PM

epriestley requested review of this revision.Jan 22 2021, 8:26 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 23 2021, 3:51 AM

Closed by commit rP16a14af2bb17: Correct the behavior of "bin/repository discover --repair" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP16a14af2bb17: Correct the behavior of "bin/repository discover --repair".

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

engine/

PhabricatorRepositoryDiscoveryEngine.php

14 lines

management/

PhabricatorRepositoryManagementDiscoverWorkflow.php

17 lines

Diff 51207

src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php

Loading...

src/applications/repository/management/PhabricatorRepositoryManagementDiscoverWorkflow.php

Loading...