Differential D21510

Disambiguate Git ref selectors in some Git command line invocations
ClosedPublic
Actions

Authored by epriestley on Jan 12 2021, 8:11 PM.

Details

Reviewers: None
Maniphest Tasks: T13589: Git may interpret refnames as flags in some commands which accept both refs and paths
Commits: rPea9cb0b625fb: Disambiguate Git ref selectors in some Git command line invocations

Summary

Ref T13589. See that task for discussion.

Test Plan

Executed most commands via "bin/conduit" or in isolation.

Diff Detail

Repository

rP Phabricator

Branch

esc1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25010
Build 34506: Run Core Tests
Build 34505: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 12 2021, 8:11 PM

Harbormaster completed remote builds in B25009: Diff 51196.Jan 12 2021, 8:12 PM

epriestley requested review of this revision.Jan 12 2021, 8:13 PM

Include fix for a "blame" callsite.

Harbormaster completed remote builds in B25010: Diff 51197.Jan 12 2021, 8:45 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 13 2021, 8:31 PM

Closed by commit rPea9cb0b625fb: Disambiguate Git ref selectors in some Git command line invocations (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPea9cb0b625fb: Disambiguate Git ref selectors in some Git command line invocations.

epriestley mentioned this in D21511: Further correct and disambigutate ref selectors passed to Git on the CLI.Jan 20 2021, 7:44 PM

epriestley mentioned this in rP0e28105ff76b: Further correct and disambigutate ref selectors passed to Git on the CLI.Jan 20 2021, 8:07 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

conduit/

DiffusionBrowseQueryConduitAPIMethod.php

15 lines

DiffusionExistsQueryConduitAPIMethod.php

2 lines

DiffusionHistoryQueryConduitAPIMethod.php

2 lines

DiffusionLastModifiedQueryConduitAPIMethod.php

2 lines

DiffusionMergedCommitsQueryConduitAPIMethod.php

8 lines

DiffusionQueryPathsConduitAPIMethod.php

2 lines

DiffusionSearchQueryConduitAPIMethod.php

2 lines

query/

blame/

DiffusionGitBlameQuery.php

2 lines

filecontent/

DiffusionGitFileContentQuery.php

2 lines

lowlevel/

DiffusionLowLevelParentsQuery.php

4 lines

rawdiff/

DiffusionGitRawDiffQuery.php

6 lines

Diff 51197

View Options

src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php

View Options

src/applications/diffusion/conduit/DiffusionExistsQueryConduitAPIMethod.php

View Options

src/applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php

View Options

src/applications/diffusion/conduit/DiffusionLastModifiedQueryConduitAPIMethod.php

View Options

src/applications/diffusion/conduit/DiffusionMergedCommitsQueryConduitAPIMethod.php

View Options

src/applications/diffusion/conduit/DiffusionQueryPathsConduitAPIMethod.php

View Options

src/applications/diffusion/conduit/DiffusionSearchQueryConduitAPIMethod.php

View Options

src/applications/diffusion/query/blame/DiffusionGitBlameQuery.php

View Options

src/applications/diffusion/query/filecontent/DiffusionGitFileContentQuery.php

View Options

src/applications/diffusion/query/lowlevel/DiffusionLowLevelParentsQuery.php

View Options

src/applications/diffusion/query/rawdiff/DiffusionGitRawDiffQuery.php

Disambiguate Git ref selectors in some Git command line invocationsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 51197

src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php

src/applications/diffusion/conduit/DiffusionExistsQueryConduitAPIMethod.php

src/applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php

src/applications/diffusion/conduit/DiffusionLastModifiedQueryConduitAPIMethod.php

src/applications/diffusion/conduit/DiffusionMergedCommitsQueryConduitAPIMethod.php

src/applications/diffusion/conduit/DiffusionQueryPathsConduitAPIMethod.php

src/applications/diffusion/conduit/DiffusionSearchQueryConduitAPIMethod.php

src/applications/diffusion/query/blame/DiffusionGitBlameQuery.php

src/applications/diffusion/query/filecontent/DiffusionGitFileContentQuery.php

src/applications/diffusion/query/lowlevel/DiffusionLowLevelParentsQuery.php

src/applications/diffusion/query/rawdiff/DiffusionGitRawDiffQuery.php

Disambiguate Git ref selectors in some Git command line invocations
ClosedPublic
Actions

Revision Contents
Changeset List