Page MenuHomePhabricator
Differential D21508

Support "control" and "return/enter" in the remarkup rule for keystrokes
ClosedPublic
Actions

Authored by epriestley on Jan 12 2021, 3:43 AM.
Tags
None
Referenced Files
F14800858: D21508.id51194.diff
Sat, Jan 25, 8:49 AM
F14800857: D21508.id51193.diff
Sat, Jan 25, 8:49 AM
F14800855: D21508.id.diff
Sat, Jan 25, 8:49 AM
Unknown Object (File)
Tue, Jan 21, 10:30 AM
Unknown Object (File)
Thu, Jan 16, 7:38 AM
Unknown Object (File)
Fri, Jan 10, 10:35 PM
Unknown Object (File)
Wed, Jan 1, 9:30 PM
Unknown Object (File)
Dec 12 2024, 12:40 AM
View All 79 Files
Subscribers
None

Details

Reviewers
None
Commits
rPc63c2aadef3a: Support "control" and "return/enter" in the remarkup rule for keystrokes
Summary

These characters are missing support in {key ...} but are reasonable to include.

Test Plan

Screen Shot 2021-01-11 at 7.41.17 PM.png (459×436 px, 23 KB)

Diff Detail

Repository
rP Phabricator
Branch
return1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25006
Build 34499: Run Core Tests
Build 34498: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 12 2021, 3:43 AM
Harbormaster completed remote builds in B25006: Diff 51193.Jan 12 2021, 3:44 AM
epriestley requested review of this revision.Jan 12 2021, 3:44 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 12 2021, 3:47 AM
Closed by commit rPc63c2aadef3a: Support "control" and "return/enter" in the remarkup rule for keystrokes (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPc63c2aadef3a: Support "control" and "return/enter" in the remarkup rule for keystrokes.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
markup/
rule/
16 lines

Diff 51193

View Options

src/infrastructure/markup/rule/PhabricatorKeyboardRemarkupRule.php

Loading...
Phabricator · Built by Phacility