Support "control" and "return/enter" in the remarkup rule for keystrokes
ClosedPublic
Actions

Authored by epriestley on Jan 12 2021, 3:43 AM.

Tags

None

Referenced Files

	F19507976: D21508.diff
	Sat, Jan 10, 12:22 AM

	F19093492: D21508.id.diff
	Dec 3 2025, 9:42 PM

	F18901001: D21508.id.diff
	Nov 7 2025, 9:33 PM

	F18878168: D21508.id51194.diff
	Nov 6 2025, 3:28 PM

	F18877494: D21508.id51193.diff
	Nov 6 2025, 9:18 AM

	F18856950: D21508.diff
	Nov 1 2025, 12:21 PM

	F18596289: D21508.diff
	Sep 13 2025, 12:17 AM

	F18589061: D21508.diff
	Sep 12 2025, 2:19 AM

View All Files

Subscribers

None

Details

Reviewers: None
Commits: rPc63c2aadef3a: Support "control" and "return/enter" in the remarkup rule for keystrokes

Summary

These characters are missing support in {key ...} but are reasonable to include.

Test Plan

Screen Shot 2021-01-11 at 7.41.17 PM.png (459×436 px, 23 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 12 2021, 3:43 AM

Harbormaster completed remote builds in B25006: Diff 51193.Jan 12 2021, 3:44 AM

epriestley requested review of this revision.Jan 12 2021, 3:44 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 12 2021, 3:47 AM

Closed by commit rPc63c2aadef3a: Support "control" and "return/enter" in the remarkup rule for keystrokes (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPc63c2aadef3a: Support "control" and "return/enter" in the remarkup rule for keystrokes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

markup/

rule/

PhabricatorKeyboardRemarkupRule.php

16 lines

Diff 51194

View Options

src/infrastructure/markup/rule/PhabricatorKeyboardRemarkupRule.php

Support "control" and "return/enter" in the remarkup rule for keystrokesClosedPublicActions