Page MenuHomePhabricator
Differential D21489

Add a basic "harbormaster.step.edit" API method
ClosedPublic
Actions

Authored by epriestley on Nov 3 2020, 8:46 PM.
Tags
None
Referenced Files
F18783504: D21489.id.diff
Mon, Oct 13, 7:17 AM
F18757479: D21489.id51147.diff
Sun, Oct 5, 5:38 PM
F18718328: D21489.id51148.diff
Mon, Sep 29, 3:30 PM
F18703558: D21489.diff
Sun, Sep 28, 4:24 AM
F18691540: D21489.id51147.diff
Fri, Sep 26, 9:23 PM
F18691019: D21489.id.diff
Fri, Sep 26, 8:32 PM
F18597635: D21489.id.diff
Sep 13 2025, 3:21 AM
F18590044: D21489.diff
Sep 12 2025, 5:01 AM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13585: Expose "harbormaster.step.edit" and "harbormaster.step.search" over Conduit
Commits
rP34082efb02c7: Add a basic "harbormaster.step.edit" API method
Summary

Ref T13585. Provide a minimal but technically functional "harbormaster.step.edit" API method.

Test Plan

Used the web console to modify the URI for a "Make HTTP Request" build step.

Diff Detail

Repository
rP Phabricator
Branch
step2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24961
Build 34441: Run Core Tests
Build 34440: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 3 2020, 8:46 PM
Owners added a subscriber: Restricted Owners Package.Nov 3 2020, 8:46 PM
Harbormaster completed remote builds in B24961: Diff 51147.Nov 3 2020, 8:47 PM
epriestley requested review of this revision.Nov 3 2020, 8:47 PM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 3 2020, 8:50 PM
Closed by commit rP34082efb02c7: Add a basic "harbormaster.step.edit" API method (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP34082efb02c7: Add a basic "harbormaster.step.edit" API method.

Revision Contents
Changeset List

PathSize
src/
applications/
harbormaster/
conduit/
20 lines
editor/
107 lines

Diff 51147

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/harbormaster/conduit/HarbormasterBuildStepEditAPIMethod.php

Loading...
View Options

src/applications/harbormaster/editor/HarbormasterBuildStepEditEngine.php

Loading...
Phabricator · Built by Phacility