Fix an issue where "phutil_utf8v()" could fatal when passed an integer
ClosedPublic
Actions

Authored by epriestley on Oct 16 2020, 4:20 PM.

Details

Reviewers: None
Commits: rARCccf74a40dd3b: Fix an issue where "phutil_utf8v()" could fatal when passed an integer

Summary

See https://discourse.phabricator-community.org/t/search-by-name-in-files-doesnt-support-number/4300.

I can't exactly reproduce the original issue, but when a query like "quack 1234" is tokenized, we end up calling "phutil_utf8v(1234)", where the argument is an integer.

At least in recent versions of PHP, this fatals ("trying to access an offset of an integer"). Cast the argument first.

Test Plan

Searched for "quack 1234" in Files. Before: fatal accessing offset of integer; after: correct results.

Diff Detail

Repository

rARC Arcanist

Branch

utf8str

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24935
Build 34402: Run Core Tests
Build 34401: arc lint + arc unit

Event Timeline

epriestley created this revision.Oct 16 2020, 4:20 PM

Harbormaster completed remote builds in B24935: Diff 51120.Oct 16 2020, 4:20 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 16 2020, 4:20 PM

epriestley requested review of this revision.

Closed by commit rARCccf74a40dd3b: Fix an issue where "phutil_utf8v()" could fatal when passed an integer (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCccf74a40dd3b: Fix an issue where "phutil_utf8v()" could fatal when passed an integer.

epriestley mentioned this in T2312: Modifying PHP.Nov 3 2020, 6:19 PM

Revision Contents
Changeset List

Path

Size

src/

utils/

utf8.php

2 lines

Diff 51120

View Options

Fix an issue where "phutil_utf8v()" could fatal when passed an integerClosedPublicActions