Page MenuHomePhabricator

Never render "Show More Context" inside an inline comment suggestion diff
ClosedPublic

Authored by epriestley on Oct 2 2020, 4:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 25, 8:44 AM
Unknown Object (File)
Sat, Jan 25, 8:44 AM
Unknown Object (File)
Sat, Jan 25, 8:44 AM
Unknown Object (File)
Tue, Jan 21, 3:28 PM
Unknown Object (File)
Tue, Jan 21, 11:16 AM
Unknown Object (File)
Mon, Jan 6, 3:24 AM
Unknown Object (File)
Tue, Dec 31, 12:36 AM
Unknown Object (File)
Dec 8 2024, 9:02 AM
Subscribers
None

Details

Summary

See PHI1896. If you do this:

  • Create an inline comment over a wide range of lines.
  • Suggest an edit.
  • Make a change near the beginning of the block.
  • Make a change near the end of the block.
  • Save the inline.

...you get a rendering which includes a "Show More Context" fold in the middle.

Currently, this element renders in a visually broken way and consumes too many columns.

However, this element isn't ever desirable inside inline comment suggestions. Stop it from rendering entirely.

Test Plan
  • Made an inline comment suggestion across lines 1-50 with edits at the beginning and end, saw a contiguous diff.
  • Made smaller inline comment suggestions (one line, a few lines).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Oct 2 2020, 4:46 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.