Page MenuHomePhabricator

Never render "Show More Context" inside an inline comment suggestion diff
ClosedPublic

Authored by epriestley on Oct 2 2020, 4:44 PM.
Tags
None
Referenced Files
F19139581: D21476.id51119.diff
Wed, Dec 10, 11:56 AM
F19135558: D21476.id51118.diff
Wed, Dec 10, 9:02 AM
F19034217: D21476.diff
Tue, Nov 25, 1:32 PM
F19033134: D21476.diff
Tue, Nov 25, 9:09 AM
F18981695: D21476.diff
Mon, Nov 17, 4:49 AM
F18936343: D21476.diff
Nov 10 2025, 8:06 PM
F18843604: D21476.diff
Oct 28 2025, 11:39 PM
F18804381: D21476.id.diff
Oct 18 2025, 7:52 AM
Subscribers
None

Details

Summary

See PHI1896. If you do this:

  • Create an inline comment over a wide range of lines.
  • Suggest an edit.
  • Make a change near the beginning of the block.
  • Make a change near the end of the block.
  • Save the inline.

...you get a rendering which includes a "Show More Context" fold in the middle.

Currently, this element renders in a visually broken way and consumes too many columns.

However, this element isn't ever desirable inside inline comment suggestions. Stop it from rendering entirely.

Test Plan
  • Made an inline comment suggestion across lines 1-50 with edits at the beginning and end, saw a contiguous diff.
  • Made smaller inline comment suggestions (one line, a few lines).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Oct 2 2020, 4:46 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.