Fix an issue where known Subversion commits are incorrectly shown as "Discovering..."
ClosedPublic
Actions

Authored by epriestley on Sep 17 2020, 8:52 PM.

Details

Reviewers: None
Maniphest Tasks: T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch
Commits: rP58d3f6145a85: Fix an issue where known Subversion commits are incorrectly shown as…

Summary

Ref T13552. The behavior of "RepositoryQuery" with ambiguous identifiers under "withRepositoryPHIDs()" is tricky. This leads to failure to load commits in Subversion in some cases.

Use "withRepository()", which gives us the correct identifier resolution behavior.

Test Plan

Viewed a subversion repository history in Diffusion, saw commit details after change.

Diff Detail

Repository

rP Phabricator

Branch

subversion1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24915
Build 34374: Run Core Tests
Build 34373: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 17 2020, 8:52 PM

Harbormaster completed remote builds in B24915: Diff 51100.Sep 17 2020, 8:53 PM

epriestley requested review of this revision.Sep 17 2020, 8:53 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 17 2020, 8:55 PM

Closed by commit rP58d3f6145a85: Fix an issue where known Subversion commits are incorrectly shown as… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP58d3f6145a85: Fix an issue where known Subversion commits are incorrectly shown as….

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

view/

DiffusionCommitGraphView.php

2 lines

Diff 51100

View Options

src/applications/diffusion/view/DiffusionCommitGraphView.php

Fix an issue where known Subversion commits are incorrectly shown as "Discovering..."ClosedPublicActions