Page MenuHomePhabricator

Fix an out-of-order issue in the new update-during-publish behavior
ClosedPublic

Authored by epriestley on Sep 17 2020, 8:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 7, 9:15 AM
Unknown Object (File)
Feb 20 2024, 8:22 AM
Unknown Object (File)
Feb 19 2024, 7:47 AM
Unknown Object (File)
Feb 7 2024, 9:43 PM
Unknown Object (File)
Jan 31 2024, 8:20 AM
Unknown Object (File)
Dec 14 2023, 8:13 PM
Unknown Object (File)
Dec 12 2023, 2:30 AM
Unknown Object (File)
Nov 30 2023, 4:38 AM
Subscribers
None

Details

Summary

Ref T13552. The Herald field "Accepted Differential revision" (and similar fields) depend on the task/revision update steps running before Herald executes.

Herald currently executes first, so it never sees associated revisions. Swap this order.

Test Plan

Published a commit, got a clean parse/import. Will test with production rules ("Cowboy Commits").

Diff Detail

Repository
rP Phabricator
Branch
publish1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24913
Build 34371: Run Core Tests
Build 34370: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 17 2020, 8:39 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.