Page MenuHomePhabricator
Differential D21465

Add missing indexes to DrydockRepositoryOperation
ClosedPublic
Actions

Authored by epriestley on Sep 17 2020, 7:08 PM.
Tags
None
Referenced Files
F17945480: D21465.diff
Thu, Jul 31, 12:13 PM
F17756202: D21465.id51093.diff
Tue, Jul 22, 1:51 PM
F17756201: D21465.id51092.diff
Tue, Jul 22, 1:51 PM
F17756013: D21465.id.diff
Tue, Jul 22, 1:32 PM
F17732044: D21465.diff
Sun, Jul 20, 3:51 AM
Unknown Object (File)
Wed, Jul 2, 7:33 PM
Unknown Object (File)
Apr 27 2025, 8:17 PM
Unknown Object (File)
Apr 27 2025, 9:11 AM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Commits
rPa754c694deab: Add missing indexes to DrydockRepositoryOperation
Summary

See PHI1885. Repository operations are queryable by state and author, but neither column has a usable key. Add usable keys.

Test Plan

Ran EXPLAIN on a state query. Ran bin/storage upgrade. Ran EXPLAIN again, saw query go from a table scan to a const key lookup.

Diff Detail

Repository
rP Phabricator
Branch
drydock1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24907
Build 34362: Run Core Tests
Build 34361: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 17 2020, 7:08 PM
Owners added a subscriber: Restricted Owners Package.Sep 17 2020, 7:08 PM
Harbormaster completed remote builds in B24907: Diff 51092.Sep 17 2020, 7:09 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 17 2020, 7:09 PM
epriestley requested review of this revision.
Closed by commit rPa754c694deab: Add missing indexes to DrydockRepositoryOperation (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in rPa754c694deab: Add missing indexes to DrydockRepositoryOperation.
epriestley added a commit: rPa754c694deab: Add missing indexes to DrydockRepositoryOperation.

Revision Contents
Changeset List

PathSize
src/
applications/
drydock/
storage/
6 lines

Diff 51092

View Options

src/applications/drydock/storage/DrydockRepositoryOperation.php

Loading...
Phabricator · Built by Phacility