Page MenuHomePhabricator

Move task and revision closure to the "publishing" step of the commit import pipeline
ClosedPublic

Authored by epriestley on Aug 12 2020, 9:19 PM.
Tags
None
Referenced Files
F12841233: D21450.diff
Thu, Mar 28, 9:03 PM
Unknown Object (File)
Feb 19 2024, 10:29 AM
Unknown Object (File)
Feb 19 2024, 7:47 AM
Unknown Object (File)
Dec 24 2023, 2:56 PM
Unknown Object (File)
Dec 12 2023, 2:28 AM
Unknown Object (File)
Nov 30 2023, 4:38 AM
Unknown Object (File)
Nov 17 2023, 1:07 PM
Unknown Object (File)
Oct 22 2023, 6:32 AM
Subscribers
None

Details

Summary

Ref T13552. Now that these steps can build their own "CommitRef" object from storage on the "CommitData" object, move them from the "Message" step to the "Publishing" step.

This should resolve the root issue in T13552, where a commit moved from a non-permanent branch to a permanent branch does not publish closures properly.

Test Plan

Used "bin/repository reparse --publish ..." to republish changes.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:37 AM
This revision was automatically updated to reflect the committed changes.