Differential D21441

Delete some commit dead parsing code
ClosedPublic
Actions

Authored by epriestley on Aug 12 2020, 4:31 PM.

Details

Reviewers: None
Maniphest Tasks: T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch
Commits: rP367cd289270d: Delete some commit dead parsing code

Summary

Ref T13552. Neither "$hashes" or "$user" are used, and constructing them has no side effects.

Test Plan

Searched for these symbols.

Diff Detail

Repository

rP Phabricator

Branch

cref1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24855
Build 34285: Run Core Tests
Build 34284: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 12 2020, 4:31 PM

Harbormaster completed remote builds in B24855: Diff 51040.Aug 12 2020, 4:32 PM

epriestley requested review of this revision.Aug 12 2020, 4:32 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:36 AM

Closed by commit rP367cd289270d: Delete some commit dead parsing code (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP367cd289270d: Delete some commit dead parsing code.

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

worker/

commitmessageparser/

PhabricatorRepositoryCommitMessageParserWorker.php

8 lines

Diff 51040

View Options

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

Delete some commit dead parsing codeClosedPublicActions