Page MenuHomePhabricator

Improve commit action item layout on mobile
ClosedPublic

Authored by epriestley on Jul 28 2020, 5:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 1:43 AM
Unknown Object (File)
Thu, Apr 18, 4:25 AM
Unknown Object (File)
Sat, Apr 13, 11:03 AM
Unknown Object (File)
Feb 19 2024, 7:47 AM
Unknown Object (File)
Feb 2 2024, 1:49 AM
Unknown Object (File)
Jan 21 2024, 5:41 AM
Unknown Object (File)
Jan 16 2024, 1:25 AM
Unknown Object (File)
Jan 9 2024, 7:21 AM
Subscribers
None

Details

Summary

Ref T13552. Build the "commit list" elements so that the menu action items collapse under the element on mobile.

Also change the mobile breakpoint to 512px because my Safari window can't go any narrower than 508px. Future changes to responsive design will be more content-aware anyway.

Test Plan

Looked at commits in various interfaces, at desktop and mobile widths.

Diff Detail

Repository
rP Phabricator
Branch
publish16
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 24811
Build 34229: Run Core Tests
Build 34228: arc lint + arc unit

Unit TestsFailed

TimeTest
305 msPhabricatorCelerityTestCase::testCelerityMaps
Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
196 msPhabricatorCelerityTestCase::testCelerityMaps
Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
50 msPhabricatorLocalTimeTestCase::testLocalTimeFormatting
EXCEPTION (Exception): Expected to find 1 project(s) (interns), found 0. #0 /Users/epriestley/dev/core/lib/arcanist/src/events/PhutilEventEngine.php(65): OnVerifyEmailListener->handleEvent(Object(PhabricatorEvent)) #1 /Users/epriestley/dev/core/lib/phabricator/src/applications/people/editor/PhabricatorUserEditor.php(508): PhutilEventEngine::dispatchEvent(Object(PhabricatorEvent))
0 msAlmanacNamesTestCase::testServiceOrDeviceNames
30 assertions passed.
0 msAlmanacServiceTypeTestCase::testGetAllServiceTypes
1 assertion passed.
View Full Test Results (3 Failed · 433 Passed · 2 Skipped)

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 28 2020, 5:09 PM
Harbormaster failed remote builds in B24811: Diff 50994!
This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2020, 4:04 PM
This revision was automatically updated to reflect the committed changes.