Improve commit action item layout on mobile
ClosedPublic
Actions

Authored by epriestley on Jul 28 2020, 5:08 PM.

Details

Reviewers: None
Maniphest Tasks: T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch
Commits: rP49af92e90325: Improve commit action item layout on mobile

Summary

Ref T13552. Build the "commit list" elements so that the menu action items collapse under the element on mobile.

Also change the mobile breakpoint to 512px because my Safari window can't go any narrower than 508px. Future changes to responsive design will be more content-aware anyway.

Test Plan

Looked at commits in various interfaces, at desktop and mobile widths.

Diff Detail

Repository

rP Phabricator

Branch

publish16

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 24811
Build 34229: Run Core Tests
Build 34228: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	305 ms	PhabricatorCelerityTestCase::testCelerityMaps Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
	196 ms	PhabricatorCelerityTestCase::testCelerityMaps Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
	50 ms	PhabricatorLocalTimeTestCase::testLocalTimeFormatting EXCEPTION (Exception): Expected to find 1 project(s) (interns), found 0. #0 /Users/epriestley/dev/core/lib/arcanist/src/events/PhutilEventEngine.php(65): OnVerifyEmailListener->handleEvent(Object(PhabricatorEvent)) #1 /Users/epriestley/dev/core/lib/phabricator/src/applications/people/editor/PhabricatorUserEditor.php(508): PhutilEventEngine::dispatchEvent(Object(PhabricatorEvent))
	0 ms	AlmanacNamesTestCase::testServiceOrDeviceNames 30 assertions passed.
	0 ms	AlmanacServiceTypeTestCase::testGetAllServiceTypes 1 assertion passed.
		View Full Test Results (3 Failed · 433 Passed · 2 Skipped)