Page MenuHomePhabricator
Differential D21414

Remove "DiffusionHistoryTableView" and "DiffusionHistoryView"
ClosedPublic
Actions

Authored by epriestley on Jul 12 2020, 4:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 28, 1:09 AM
Unknown Object (File)
Sat, Jan 25, 8:30 AM
Unknown Object (File)
Sat, Jan 25, 8:30 AM
Unknown Object (File)
Sat, Jan 25, 8:30 AM
Unknown Object (File)
Sat, Jan 25, 8:30 AM
Unknown Object (File)
Thu, Jan 23, 5:24 PM
Unknown Object (File)
Tue, Jan 21, 11:18 AM
Unknown Object (File)
Sun, Jan 19, 11:29 PM
View All 100 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch
Commits
rP2b0632b442a2: Remove "DiffusionHistoryTableView" and "DiffusionHistoryView"
Summary

Ref T13552.

Currently, the "Browse" page shows a snippet of unmerged changes if you're looking at a non-default branch. Remove this for consistency with the simplified main "Browse" page. This is reachable via "Compare".

Update the "Compare" page to use the new "CommitGraphView".

Test Plan
  • Looked at the "Browse" page of "stable".
  • Looked at the "Compare" page for "stable vs master".

Diff Detail

Repository
rP Phabricator
Branch
publish11
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24779
Build 34180: Run Core Tests
Build 34179: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 12 2020, 4:25 PM
Harbormaster completed remote builds in B24779: Diff 50959.Jul 12 2020, 4:26 PM
epriestley requested review of this revision.Jul 12 2020, 4:26 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2020, 4:00 PM
Closed by commit rP2b0632b442a2: Remove "DiffusionHistoryTableView" and "DiffusionHistoryView" (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP2b0632b442a2: Remove "DiffusionHistoryTableView" and "DiffusionHistoryView".

Revision Contents
Changeset List

Diff 50959

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCompareController.php

Loading...
View Options

src/applications/diffusion/view/DiffusionHistoryTableView.php

Loading...
View Options

src/applications/diffusion/view/DiffusionHistoryView.php

Loading...
Phabricator · Built by Phacility