Differential D21410

Introduce "DiffusionCommitGraphView", which unifies "HistoryListView" and "HistoryTableView"
ClosedPublic
Actions

Authored by epriestley on Jul 10 2020, 6:20 PM.

Tags

None

Referenced Files

	F15037784: D21410.diff
	Sun, Feb 16, 10:23 PM

	Unknown Object (File)
	Sun, Feb 9, 9:46 AM

	Unknown Object (File)
	Sun, Feb 9, 9:46 AM

	Unknown Object (File)
	Sun, Feb 9, 9:45 AM

	Unknown Object (File)
	Sun, Feb 9, 9:45 AM

	Unknown Object (File)
	Tue, Jan 28, 1:06 AM

	Unknown Object (File)
	Mon, Jan 27, 2:37 AM

	Unknown Object (File)
	Sat, Jan 25, 8:29 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch
Commits: rP46695c76ebfe: Introduce "DiffusionCommitGraphView", which unifies "HistoryListView" and…

Summary

Ref T13552. Currently, commit lists are sometimes rendered as an object list and sometimes rendered as a table. There are two separate views for table rendering.

Add a fourth view ("list, with a graph") with the eventual intent of unifying all the other views. For now, this only replaces "HistoryListView" -- and needs some more work to really be a convincing replacement.

Test Plan

Looked at "History" in Diffusion, saw an ugly view with all the information we want.
Grepped for "HistoryListView", no hits.

Diff Detail

Repository

Branch

publish7

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24772
Build 34168: Run Core Tests
Build 34167: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 10 2020, 6:20 PM

Harbormaster completed remote builds in B24772: Diff 50953.Jul 10 2020, 6:22 PM

epriestley requested review of this revision.Jul 10 2020, 6:22 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2020, 3:59 PM

Closed by commit rP46695c76ebfe: Introduce "DiffusionCommitGraphView", which unifies "HistoryListView" and… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP46695c76ebfe: Introduce "DiffusionCommitGraphView", which unifies "HistoryListView" and….

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

diffusion/

controller/

DiffusionHistoryController.php

25 lines

view/

DiffusionCommitGraphView.php

415 lines

DiffusionHistoryListView.php

Diff 50953

src/__phutil_library_map__.php

Loading...

src/applications/diffusion/controller/DiffusionHistoryController.php

Loading...

src/applications/diffusion/view/DiffusionCommitGraphView.php

Loading...

src/applications/diffusion/view/DiffusionHistoryListView.php

Loading...