Page MenuHomePhabricator
Differential D21409

Remove the "Graph" view as a dedicated repository view
ClosedPublic
Actions

Authored by epriestley on Jul 10 2020, 5:56 PM.
Tags
None
Referenced Files
F15377670: D21409.id50952.diff
Thu, Mar 13, 10:07 AM
F15334042: D21409.diff
Sat, Mar 8, 6:24 AM
F15332786: D21409.id.diff
Fri, Mar 7, 8:20 PM
F15298700: D21409.diff
Wed, Mar 5, 1:38 PM
F15286208: D21409.id.diff
Tue, Mar 4, 7:05 PM
F15286201: D21409.id51026.diff
Tue, Mar 4, 7:03 PM
F15284947: D21409.id50952.diff
Tue, Mar 4, 11:03 AM
Unknown Object (File)
Fri, Feb 21, 3:56 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch
Commits
rPc6de7c66a3c6: Remove the "Graph" view as a dedicated repository view
Summary

Ref T13552. Currently, Diffusion has two effectively identical history views, the "Graph" view and the "History" view.

These arose out of product uncertainty about the importance of the graph, but I think we can just put the graph on the "object item list" view and merge these views.

Test Plan

Looked at repositories in Diffusion, no longer saw a "Graph" tab. Grepped for "graph"-related symbols.

Diff Detail

Repository
rP Phabricator
Branch
publish6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24771
Build 34166: Run Core Tests
Build 34165: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 10 2020, 5:56 PM
Harbormaster completed remote builds in B24771: Diff 50952.Jul 10 2020, 5:57 PM
epriestley requested review of this revision.Jul 10 2020, 5:57 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2020, 3:59 PM
Closed by commit rPc6de7c66a3c6: Remove the "Graph" view as a dedicated repository view (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPc6de7c66a3c6: Remove the "Graph" view as a dedicated repository view.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
application/
1 line
controller/
14 lines
repository/
storage/
2 lines

Diff 50952

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/application/PhabricatorDiffusionApplication.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionGraphController.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
Phabricator · Built by Phacility