Page MenuHomePhabricator

Expand Revision transaction API to allow actions to vary more broadly based on the viewer and revision state
ClosedPublic

Authored by epriestley on Jul 9 2020, 7:29 PM.
Tags
None
Referenced Files
F13087736: D21401.diff
Thu, Apr 25, 1:04 AM
Unknown Object (File)
Sat, Mar 30, 11:16 AM
Unknown Object (File)
Jan 19 2024, 3:19 PM
Unknown Object (File)
Jan 17 2024, 8:12 PM
Unknown Object (File)
Jan 11 2024, 10:29 AM
Unknown Object (File)
Dec 26 2023, 7:22 PM
Unknown Object (File)
Dec 21 2023, 9:49 AM
Unknown Object (File)
Dec 17 2023, 8:20 AM
Subscribers
None

Details

Summary

See PHI1810. Build toward support for "Request Review" by non-authors on drafts, to forcefully pull a revision out of draft.

Currently, some action strings can't vary based on revision state or the current viewer, so this "pull out of draft" action would have to either: say "Request Review"; or be a totally separate action.

Neither seem great, so allow the labels and messages to vary based on the viewer and revision state.

Test Plan

Grepped for affected symbols, see followup changes.

Diff Detail

Repository
rP Phabricator
Branch
request1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24760
Build 34147: Run Core Tests
Build 34146: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jul 9 2020, 9:20 PM
This revision was automatically updated to reflect the committed changes.