Page MenuHomePhabricator

When "arc land" fails a Mercurial push, actually raise it as an exception
ClosedPublic

Authored by epriestley on Jul 8 2020, 9:11 PM.

Details

Summary

See PHI1808. Some refactoring of the "passthru" API resulted in error conditinos here being dropped. Instead, raise them as exceptions.

Test Plan

Forced "hg push" to fail, used "arc land" against a failed push, saw error behavior instead of "success" feedback.

Diff Detail

Repository
rARC Arcanist
Branch
hg4
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 24746
Build 34126: Run Core Tests
Build 34125: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jul 8 2020, 10:30 PM
This revision was automatically updated to reflect the committed changes.