Page MenuHomePhabricator
Differential D21394

When "arc land" fails a Mercurial push, actually raise it as an exception
ClosedPublic
Actions

Authored by epriestley on Jul 8 2020, 9:11 PM.
Tags
None
Referenced Files
F15488562: D21394.id50930.diff
Thu, Apr 10, 11:28 PM
F15468002: D21394.id.diff
Thu, Apr 3, 7:13 PM
F15463990: D21394.diff
Wed, Apr 2, 5:15 AM
F15418482: D21394.diff
Mar 20 2025, 11:35 PM
F15391212: D21394.diff
Mar 15 2025, 8:45 AM
F15337389: D21394.diff
Mar 9 2025, 5:38 AM
F15333680: D21394.diff
Mar 8 2025, 4:00 AM
F15331629: D21394.id50930.diff
Mar 7 2025, 12:02 PM
View All Files
Subscribers
None

Details

Reviewers
None
Commits
rARC710bceab1031: When "arc land" fails a Mercurial push, actually raise it as an exception
Summary

See PHI1808. Some refactoring of the "passthru" API resulted in error conditinos here being dropped. Instead, raise them as exceptions.

Test Plan

Forced "hg push" to fail, used "arc land" against a failed push, saw error behavior instead of "success" feedback.

Diff Detail

Repository
rARC Arcanist
Branch
hg4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24746
Build 34126: Run Core Tests
Build 34125: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 8 2020, 9:11 PM
Harbormaster completed remote builds in B24746: Diff 50927.Jul 8 2020, 9:11 PM
epriestley requested review of this revision.Jul 8 2020, 9:11 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 8 2020, 10:30 PM
Closed by commit rARC710bceab1031: When "arc land" fails a Mercurial push, actually raise it as an exception (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARC710bceab1031: When "arc land" fails a Mercurial push, actually raise it as an exception.

Revision Contents
Changeset List

PathSize
src/
land/
engine/
7 lines

Diff 50927

View Options

src/land/engine/ArcanistMercurialLandEngine.php

Loading...
Phabricator · Built by Phacility