Fix additional Mercurial/Python compatibility issues in "arc land"
ClosedPublic
Actions

Authored by epriestley on Jul 7 2020, 5:19 PM.

Details

Reviewers: None
Commits: rARCe3ed781f363d: (stable) Fix additional Mercurial/Python compatibility issues in "arc land"
rARC41774ba9cceb: Fix additional Mercurial/Python compatibility issues in "arc land"

Summary

Ref PHI1805. Under some combination of versions (Python 3.8?), "arc-ls-markers" is running into additional Python runtime issues.

Sprinkle more "b" around to resolve them? Also clean up a couple of plain "arc" issues.

Test Plan

Landed a change in Mercurial.

Some of this works fine without changes in Python 3.7/2.7 against Mercurial 4.7/5.4, so this may not be exhaustive.

Diff Detail

Repository

rARC Arcanist

Branch

hg3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24743
Build 34122: Run Core Tests
Build 34121: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 7 2020, 5:19 PM

Harbormaster completed remote builds in B24743: Diff 50924.Jul 7 2020, 5:19 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 7 2020, 5:19 PM

epriestley requested review of this revision.

Closed by commit rARC41774ba9cceb: Fix additional Mercurial/Python compatibility issues in "arc land" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC41774ba9cceb: Fix additional Mercurial/Python compatibility issues in "arc land".

epriestley added a commit: rARCe3ed781f363d: (stable) Fix additional Mercurial/Python compatibility issues in "arc land".Jul 7 2020, 5:21 PM

Revision Contents
Changeset List

Path

Size

src/

land/

engine/

ArcanistMercurialLandEngine.php

6 lines

support/

hg/

arc-hg.py

14 lines

Diff 50924

View Options

src/land/engine/ArcanistMercurialLandEngine.php