Differential D21388

Clean up some service profiler behavior in Conduit futures
ClosedPublic
Actions

Authored by epriestley on Jul 1 2020, 1:24 PM.

Tags

None

Referenced Files

	F15375138: D21388.diff
	Wed, Mar 12, 9:48 PM

	F15335442: D21388.id50913.diff
	Sat, Mar 8, 3:25 PM

	F15334511: D21388.diff
	Sat, Mar 8, 10:05 AM

	F15331484: D21388.id.diff
	Fri, Mar 7, 10:36 AM

	F15311758: D21388.id50904.diff
	Thu, Mar 6, 10:45 AM

	Unknown Object (File)
	Tue, Feb 25, 8:04 AM

	Unknown Object (File)
	Jan 28 2025, 6:40 PM

	Unknown Object (File)
	Jan 27 2025, 6:50 AM

Subscribers

None

Details

Reviewers: None
Commits: rARC01e91dc260a7: Clean up some service profiler behavior in Conduit futures

Summary

Correct two minor Conduit future issues:

FutureAgent shows up in the trace log as "<mystery>". Since it isn't doing anything useful, solve the mystery and drop it from the log.
Simply the ConduitFuture code for interacting with the service profiler now that a more structured integration is available.

Test Plan

Ran "arc branches --trace", saw conduit calls and no more "<mystery>" clutter.

Diff Detail

Repository

Branch

future7

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24722
Build 34095: Run Core Tests
Build 34094: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 1 2020, 1:24 PM

Harbormaster completed remote builds in B24722: Diff 50904.Jul 1 2020, 1:25 PM

epriestley requested review of this revision.Jul 1 2020, 1:25 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 1 2020, 1:37 PM

Closed by commit rARC01e91dc260a7: Clean up some service profiler behavior in Conduit futures (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC01e91dc260a7: Clean up some service profiler behavior in Conduit futures.

Revision Contents
Changeset List

Path

Size

src/

conduit/

ConduitFuture.php

29 lines

FutureAgent.php

7 lines

future/

4 lines

Diff 50904

src/conduit/ConduitFuture.php

Loading...

src/conduit/FutureAgent.php

Loading...

src/future/Future.php

Loading...