Page MenuHomePhabricator

Clean up some service profiler behavior in Conduit futures
ClosedPublic

Authored by epriestley on Jul 1 2020, 1:24 PM.
Tags
None
Referenced Files
F18765024: D21388.id50904.diff
Tue, Oct 7, 9:08 AM
F18761709: D21388.diff
Mon, Oct 6, 3:50 PM
F18757659: D21388.id50913.diff
Sun, Oct 5, 6:40 PM
F18679355: D21388.id.diff
Fri, Sep 26, 12:46 AM
F18449081: D21388.diff
Aug 31 2025, 11:49 PM
F18157926: D21388.diff
Aug 14 2025, 10:31 PM
F18101222: D21388.id.diff
Aug 9 2025, 12:22 PM
F17668224: D21388.id50913.diff
Jul 12 2025, 11:01 PM
Subscribers
None

Details

Summary

Correct two minor Conduit future issues:

  • FutureAgent shows up in the trace log as "<mystery>". Since it isn't doing anything useful, solve the mystery and drop it from the log.
  • Simply the ConduitFuture code for interacting with the service profiler now that a more structured integration is available.
Test Plan

Ran "arc branches --trace", saw conduit calls and no more "<mystery>" clutter.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jul 1 2020, 1:37 PM
This revision was automatically updated to reflect the committed changes.