Page MenuHomePhabricator

Clean up some service profiler behavior in Conduit futures
ClosedPublic

Authored by epriestley on Jul 1 2020, 1:24 PM.

Details

Summary

Correct two minor Conduit future issues:

  • FutureAgent shows up in the trace log as "<mystery>". Since it isn't doing anything useful, solve the mystery and drop it from the log.
  • Simply the ConduitFuture code for interacting with the service profiler now that a more structured integration is available.
Test Plan

Ran "arc branches --trace", saw conduit calls and no more "<mystery>" clutter.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jul 1 2020, 1:24 PM
epriestley requested review of this revision.Jul 1 2020, 1:25 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 1 2020, 1:37 PM
This revision was automatically updated to reflect the committed changes.