Page MenuHomePhabricator

Clean up some service profiler behavior in Conduit futures
ClosedPublic

Authored by epriestley on Jul 1 2020, 1:24 PM.
Tags
None
Referenced Files
F12834145: D21388.diff
Thu, Mar 28, 2:28 PM
Unknown Object (File)
Feb 23 2024, 2:32 AM
Unknown Object (File)
Feb 20 2024, 4:13 AM
Unknown Object (File)
Feb 15 2024, 4:48 PM
Unknown Object (File)
Feb 14 2024, 12:37 PM
Unknown Object (File)
Feb 8 2024, 1:58 PM
Unknown Object (File)
Jan 18 2024, 11:05 AM
Unknown Object (File)
Jan 7 2024, 5:47 PM
Subscribers
None

Details

Summary

Correct two minor Conduit future issues:

  • FutureAgent shows up in the trace log as "<mystery>". Since it isn't doing anything useful, solve the mystery and drop it from the log.
  • Simply the ConduitFuture code for interacting with the service profiler now that a more structured integration is available.
Test Plan

Ran "arc branches --trace", saw conduit calls and no more "<mystery>" clutter.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jul 1 2020, 1:37 PM
This revision was automatically updated to reflect the committed changes.