Page MenuHomePhabricator

Clean up some service profiler behavior in Conduit futures
ClosedPublic

Authored by epriestley on Jul 1 2020, 1:24 PM.
Tags
None
Referenced Files
F17627972: D21388.id50913.diff
Thu, Jul 10, 7:04 AM
Unknown Object (File)
Jun 5 2025, 5:01 PM
Unknown Object (File)
Jun 4 2025, 8:46 AM
Unknown Object (File)
Jun 3 2025, 5:16 PM
Unknown Object (File)
May 6 2025, 5:50 PM
Unknown Object (File)
Apr 29 2025, 8:28 AM
Unknown Object (File)
Apr 28 2025, 5:15 PM
Unknown Object (File)
Mar 30 2025, 6:36 PM
Subscribers
None

Details

Summary

Correct two minor Conduit future issues:

  • FutureAgent shows up in the trace log as "<mystery>". Since it isn't doing anything useful, solve the mystery and drop it from the log.
  • Simply the ConduitFuture code for interacting with the service profiler now that a more structured integration is available.
Test Plan

Ran "arc branches --trace", saw conduit calls and no more "<mystery>" clutter.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jul 1 2020, 1:37 PM
This revision was automatically updated to reflect the committed changes.