Page MenuHomePhabricator

Drop intended support for "--anonymous" from Arcanist Toolsets
ClosedPublic

Authored by epriestley on Jul 1 2020, 12:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 22 2024, 2:50 PM
Unknown Object (File)
Dec 27 2023, 1:31 PM
Unknown Object (File)
Dec 27 2023, 1:31 PM
Unknown Object (File)
Dec 27 2023, 1:31 PM
Unknown Object (File)
Dec 27 2023, 1:31 PM
Unknown Object (File)
Dec 23 2023, 7:59 PM
Unknown Object (File)
Dec 22 2023, 3:12 AM
Unknown Object (File)
Dec 22 2023, 3:12 AM
Subscribers
None

Details

Summary

Currently, modern "arc" workflows accept and parse "--anonymous" but don't do anything with it.

I intend to move away from anonymous workflows, which only really supported a tiny subset of unusual workflows on open source installs but added significant complexity to login/auth behavior.

Drop support for this flag.

Test Plan

Grepped for "anonymous", didn't turn up any relevant hits.

Diff Detail

Repository
rARC Arcanist
Branch
future5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24720
Build 34091: Run Core Tests
Build 34090: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jul 1 2020, 1:37 PM
This revision was automatically updated to reflect the committed changes.