Page MenuHomePhabricator

Add "--background" and "--count" flags to "bin/webhook call"
ClosedPublic

Authored by epriestley on Fri, Jun 26, 12:49 AM.

Details

Summary

See PHI1794, which reports an issue where a large number of queued webhook calls led to connection exhaustion. To make this easier to reproduce and test, add "--count" and "--background" flags to "bin/webhook call".

This primarily supports "bin/webook call ... --background --count 10000" to quickly fill the queue with a bunch of calls.

Test Plan

Ran bin/webhook call in foreground and background modes, with and without counts. Saw appropriate console and queue behavior.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Fri, Jun 26, 12:49 AM
epriestley requested review of this revision.Fri, Jun 26, 12:51 AM
This revision was not accepted when it landed; it landed in state Needs Review.Fri, Jun 26, 1:06 AM
This revision was automatically updated to reflect the committed changes.