Add "--background" and "--count" flags to "bin/webhook call"
ClosedPublic
Actions

Authored by epriestley on Jun 26 2020, 12:49 AM.

Details

Reviewers: None
Commits: rP2a4fa80bf17d: (stable) Add "--background" and "--count" flags to "bin/webhook call"
rPd91abf50f70a: Add "--background" and "--count" flags to "bin/webhook call"

Summary

See PHI1794, which reports an issue where a large number of queued webhook calls led to connection exhaustion. To make this easier to reproduce and test, add "--count" and "--background" flags to "bin/webhook call".

This primarily supports "bin/webook call ... --background --count 10000" to quickly fill the queue with a bunch of calls.

Test Plan

Ran bin/webhook call in foreground and background modes, with and without counts. Saw appropriate console and queue behavior.

Diff Detail

Repository

rP Phabricator

Branch

webhook1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24676
Build 34029: Run Core Tests
Build 34028: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 26 2020, 12:49 AM

Harbormaster completed remote builds in B24676: Diff 50857.Jun 26 2020, 12:51 AM

epriestley requested review of this revision.Jun 26 2020, 12:51 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 26 2020, 1:06 AM

Closed by commit rPd91abf50f70a: Add "--background" and "--count" flags to "bin/webhook call" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPd91abf50f70a: Add "--background" and "--count" flags to "bin/webhook call".

epriestley added a commit: rP2a4fa80bf17d: (stable) Add "--background" and "--count" flags to "bin/webhook call".

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

management/

HeraldWebhookCallManagementWorkflow.php

86 lines

Diff 50857

View Options

src/applications/herald/management/HeraldWebhookCallManagementWorkflow.php

Add "--background" and "--count" flags to "bin/webhook call"ClosedPublicActions