Page MenuHomePhabricator

Improve the quality of SSH error messages
ClosedPublic

Authored by epriestley on Tue, Jun 16, 3:46 PM.

Details

Summary

See PHI1784. Currently, users who pass an invalid SSH command to Phabricator's SSH handler get an unhelpful error message. Make it more helpful.

Test Plan

Ran ./bin/ssh-exec with no arguments (old, helpful error), invalid arguments (before: unhelpful error; after: helpful error), and valid arguments (old, helpful behavior).

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Tue, Jun 16, 3:46 PM
epriestley requested review of this revision.Tue, Jun 16, 3:47 PM
This revision was not accepted when it landed; it landed in state Needs Review.Tue, Jun 16, 3:59 PM
This revision was automatically updated to reflect the committed changes.