Improve the quality of SSH error messages
ClosedPublic
Actions

Authored by epriestley on Jun 16 2020, 3:46 PM.

Details

Reviewers: None
Commits: rPd5a7d4081daa: (stable) Improve the quality of SSH error messages
rP9ce1271805e9: Improve the quality of SSH error messages

Summary

See PHI1784. Currently, users who pass an invalid SSH command to Phabricator's SSH handler get an unhelpful error message. Make it more helpful.

Test Plan

Ran ./bin/ssh-exec with no arguments (old, helpful error), invalid arguments (before: unhelpful error; after: helpful error), and valid arguments (old, helpful behavior).

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jun 16 2020, 3:46 PM

Harbormaster completed remote builds in B24667: Diff 50848.Jun 16 2020, 3:47 PM

epriestley requested review of this revision.Jun 16 2020, 3:47 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 16 2020, 3:59 PM

Closed by commit rP9ce1271805e9: Improve the quality of SSH error messages (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP9ce1271805e9: Improve the quality of SSH error messages.

epriestley added a commit: rPd5a7d4081daa: (stable) Improve the quality of SSH error messages.

Revision Contents
Changeset List

Path

Size

scripts/

ssh/

ssh-exec.php

51 lines

Diff 50849

View Options

Improve the quality of SSH error messagesClosedPublicActions