Page MenuHomePhabricator

Add a support class to simplify typechecking list-of-objects return values
ClosedPublic

Authored by epriestley on May 28 2020, 2:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 3:18 PM
Unknown Object (File)
Thu, Nov 14, 9:26 AM
Unknown Object (File)
Sat, Nov 9, 6:22 PM
Unknown Object (File)
Wed, Nov 6, 1:27 AM
Unknown Object (File)
Thu, Oct 24, 11:50 PM
Unknown Object (File)
Oct 18 2024, 5:50 PM
Unknown Object (File)
Oct 15 2024, 12:17 PM
Unknown Object (File)
Sep 6 2024, 8:02 AM
Subscribers
None

Details

Summary

With some frequency, code wants to assert that some "$o->m()" returns a list of objects of type X, possibly with unique values for some "getKey()"-style method result.

Existing checks via PhutilTypeMap and assert_instances_of() aren't quite powerful enough to do this while producing an easily understandable error state. We want to know that the error arose from a call to "$o->m()" in particular.

Test Plan

Currently used elsewhere, in Piledriver code.

Diff Detail

Repository
rARC Arcanist
Branch
acheck1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24525
Build 33798: Run Core Tests
Build 33797: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 28 2020, 2:33 PM
This revision was automatically updated to reflect the committed changes.