Page MenuHomePhabricator

Add a support class to simplify typechecking list-of-objects return values

Authored by epriestley on May 28 2020, 2:30 PM.



With some frequency, code wants to assert that some "$o->m()" returns a list of objects of type X, possibly with unique values for some "getKey()"-style method result.

Existing checks via PhutilTypeMap and assert_instances_of() aren't quite powerful enough to do this while producing an easily understandable error state. We want to know that the error arose from a call to "$o->m()" in particular.

Test Plan

Currently used elsewhere, in Piledriver code.

Diff Detail

rARC Arcanist
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 28 2020, 2:33 PM
This revision was automatically updated to reflect the committed changes.