Page MenuHomePhabricator

Make lint tests handle paths better and distinguish between "0" and "null" more carefully
ClosedPublic

Authored by epriestley on May 27 2020, 7:36 PM.
Tags
None
Referenced Files
F17772646: D21291.id.diff
Wed, Jul 23, 4:21 PM
F17743916: D21291.diff
Mon, Jul 21, 2:51 PM
F17672913: D21291.id50703.diff
Sun, Jul 13, 4:11 AM
Unknown Object (File)
Jun 18 2025, 6:39 PM
Unknown Object (File)
Jun 17 2025, 8:58 AM
Unknown Object (File)
May 6 2025, 4:26 AM
Unknown Object (File)
Apr 19 2025, 5:56 AM
Unknown Object (File)
Apr 16 2025, 5:38 PM
Subscribers
None

Details

Summary

Ref T13543. Currently, the cpplint tests do not function because cpplint is passed a path which does not end in a suffix it recognizes.

Change the tempfile / path code to pass linter path/to/example.c-style linters a path they expect.

Then, correct some older code which was playing it fast-and-loose with "null" vs "0".

Test Plan

Ran arc unit --everything, got a clean bill of health on all the linters I have installed. (This is probably not all tests, since I have only a subset of linters installed locally that we have code for.)

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 27 2020, 7:37 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.