Page MenuHomePhabricator

In the "cpplint" binding, raise messages on "line 0" without a line
ClosedPublic

Authored by epriestley on May 27 2020, 5:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 17, 5:25 AM
Unknown Object (File)
Mon, Jun 16, 9:11 PM
Unknown Object (File)
Mon, Jun 16, 5:49 PM
Unknown Object (File)
Sun, Jun 15, 9:54 PM
Unknown Object (File)
May 14 2025, 1:28 AM
Unknown Object (File)
May 9 2025, 5:37 PM
Unknown Object (File)
Apr 28 2025, 1:37 PM
Unknown Object (File)
Apr 24 2025, 9:40 PM
Subscribers
None

Details

Summary

Ref T13543. The "cpplint.py" script may emit messages on line 0, but Arcanist doesn't accept these messages.

This is a small piece of a whole set of broader issues, but stop the bleeding for now.

Test Plan
  • Ran arc lint example.h on a file with no #ifndef guard, and cpplint configured.
  • Cpplint raised a message at line "0".
  • Before change: arc choked when trying to render this.
  • After change: arc survives rendering.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable