Page MenuHomePhabricator

In the "cpplint" binding, raise messages on "line 0" without a line
ClosedPublic

Authored by epriestley on May 27 2020, 5:58 PM.

Details

Summary

Ref T13543. The "cpplint.py" script may emit messages on line 0, but Arcanist doesn't accept these messages.

This is a small piece of a whole set of broader issues, but stop the bleeding for now.

Test Plan
  • Ran arc lint example.h on a file with no #ifndef guard, and cpplint configured.
  • Cpplint raised a message at line "0".
  • Before change: arc choked when trying to render this.
  • After change: arc survives rendering.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.