In the "cpplint" binding, raise messages on "line 0" without a line
ClosedPublic
Actions

Authored by epriestley on May 27 2020, 5:58 PM.

Details

Reviewers: None
Maniphest Tasks: T13543: Older linters may raise unusual messages which cause errors under stricter runtime validation
Commits: rARC609c8c9fdc32: (stable) In the "cpplint" binding, raise messages on "line 0" without a line
rARC25ee39b657b8: In the "cpplint" binding, raise messages on "line 0" without a line

Summary

Ref T13543. The "cpplint.py" script may emit messages on line 0, but Arcanist doesn't accept these messages.

This is a small piece of a whole set of broader issues, but stop the bleeding for now.

Test Plan

Ran arc lint example.h on a file with no #ifndef guard, and cpplint configured.
Cpplint raised a message at line "0".
Before change: arc choked when trying to render this.
After change: arc survives rendering.

Repository

rARC Arcanist

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

This revision was not accepted when it landed; it landed in state Needs Review.May 27 2020, 5:58 PM

This revision was landed with ongoing or failed builds.

epriestley requested review of this revision.

This revision was automatically updated to reflect the committed changes.

Path

Size

src/

lint/

linter/

12 lines