Fix an issue where builds with no initiator failed to render in build plans
ClosedPublic
Actions

Authored by epriestley on May 19 2020, 4:44 PM.

Details

Reviewers: None
Commits: rP4fd7c0f7b3ca: (stable) Fix an issue where builds with no initiator failed to render in build…
rP86d6abe9db26: Fix an issue where builds with no initiator failed to render in build plans

Summary

See PHI1743. If a build has no initiator PHID, the rendering pathway incorrectly tries to access a handle for it anyway.

Test Plan

Set a build to have no initiator PHID.
Viewed the build plan for the build.
Before: fatal when trying to access the null handle.
After: clean build plan rendering.

Diff Detail

Repository

rP Phabricator

Branch

build1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24466
Build 33713: Run Core Tests
Build 33712: arc lint + arc unit

Event Timeline

epriestley created this revision.May 19 2020, 4:44 PM

Owners added a subscriber: Restricted Owners Package.May 19 2020, 4:44 PM

Harbormaster completed remote builds in B24466: Diff 50647.May 19 2020, 4:46 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 19 2020, 4:46 PM

epriestley requested review of this revision.

Closed by commit rP86d6abe9db26: Fix an issue where builds with no initiator failed to render in build plans (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP86d6abe9db26: Fix an issue where builds with no initiator failed to render in build plans.

epriestley added a commit: rP4fd7c0f7b3ca: (stable) Fix an issue where builds with no initiator failed to render in build….

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

view/

HarbormasterBuildView.php

6 lines

Diff 50647

View Options

src/applications/harbormaster/view/HarbormasterBuildView.php

Fix an issue where builds with no initiator failed to render in build plansClosedPublicActions