Page MenuHomePhabricator

Distinguish more carefully between "null" inline offsets and "0" inline offsets

Authored by epriestley on May 14 2020, 5:57 PM.



Ref T13513. Currently, when creating an inline by selecting a line range, slightly careless handling leads to an inline with "0" offsets (by passing "undefined" to the server). This causes the block to highlight every line except the last one as fully bright, which is incorrect.

An inline with "0" offsets and an inline with no offsets are different. Be more careful about passing offsets around and rendering them.

Test Plan
  • Used the line numbers to add an inline to lines 4-8 of a change.
  • Hovered the inline.
  • Saw all four lines marked as "dull"-highlighted (previously: three bright lines, one dull line).

Diff Detail

rP Phabricator
Lint Passed
No Test Coverage
Build Status
Buildable 24425
Build 33655: Run Core Tests
Build 33654: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 14 2020, 9:27 PM
This revision was automatically updated to reflect the committed changes.