Page MenuHomePhabricator

Add "HTTPSFuture->addCurlOption()" for raw access to "curl_setopt()"
ClosedPublic

Authored by epriestley on May 14 2020, 4:14 PM.

Details

Summary

Fixes T13533. This is a narrow, fragile API for a particular Kerberos use case on one install.

Test Plan
  • Set a non-scalar key, got an exception.
  • Set <"duck", "quack">, got an exception from cURL that the value was invalid.
  • Set a bunch of made-up options to arbitrary values, no errors. cURL accepts anything so there's nothing we can do about this.
  • Set CURLOPT_NOBODY and saw the request behavior change, demonstrating that the call can produce effects.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 14 2020, 4:15 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.