Differential D21241

Make "View as Document Type..." only show valid options
ClosedPublic
Actions

Authored by epriestley on May 12 2020, 8:33 PM.

Tags

None

Referenced Files

	F15532954: D21241.diff
	Wed, Apr 23, 5:44 PM

	F15525804: D21241.diff
	Mon, Apr 21, 5:00 PM

	F15461135: D21241.id50588.diff
	Tue, Apr 1, 5:32 AM

	F15460405: D21241.id50584.diff
	Mon, Mar 31, 10:44 PM

	F15460282: D21241.id50585.diff
	Mon, Mar 31, 9:25 PM

	F15455348: D21241.diff
	Sat, Mar 29, 11:42 PM

	F15426275: D21241.diff
	Mar 23 2025, 7:54 AM

	F15403295: D21241.id50588.diff
	Mar 18 2025, 2:39 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13513: Make schema changes to inlines to prepare for new inline features
Commits: rPacc1fa165519: Make "View as Document Type..." only show valid options

Summary

Ref T13513. Currently, "View as Document Type..." lists every available engine.

This is hard to get completely right because we can't always rebuild the document ref accurately in the endpoint, but try harder to fake something reasonable.

Test Plan

Used "View as Document Type..." on Jupyter notebooks, was given "Jupyter" and "Source" as options.

Diff Detail

Repository

Branch

engine2

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/differential/parser/DifferentialChangesetParser.php:1889	XHP16	TODO Comment
Advice	src/applications/system/controller/PhabricatorSystemSelectViewAsController.php:24	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 24401
Build 33619: Run Core Tests
Build 33618: arc lint + arc unit

Event Timeline

epriestley created this revision.May 12 2020, 8:33 PM

Harbormaster completed remote builds in B24401: Diff 50584.May 12 2020, 8:34 PM

epriestley requested review of this revision.May 12 2020, 8:34 PM

Also restrict the list for changes with no candidate engines.

Harbormaster completed remote builds in B24402: Diff 50585.May 12 2020, 8:39 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 12 2020, 9:25 PM

Closed by commit rPacc1fa165519: Make "View as Document Type..." only show valid options (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPacc1fa165519: Make "View as Document Type..." only show valid options.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

src/

applications/

differential/

parser/

DifferentialChangesetParser.php

20 lines

system/

controller/

PhabricatorSystemSelectViewAsController.php

15 lines

webroot/

rsrc/

js/

application/

diff/

DiffChangeset.js

6 lines

DiffChangesetList.js

4 lines

Diff 50584

resources/celerity/map.php

Loading...

src/applications/differential/parser/DifferentialChangesetParser.php

Loading...

src/applications/system/controller/PhabricatorSystemSelectViewAsController.php

Loading...

webroot/rsrc/js/application/diff/DiffChangeset.js

Loading...

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...