Page MenuHomePhabricator

Make "View as Document Type..." only show valid options
ClosedPublic

Authored by epriestley on May 12 2020, 8:33 PM.

Details

Summary

Ref T13513. Currently, "View as Document Type..." lists every available engine.

This is hard to get completely right because we can't always rebuild the document ref accurately in the endpoint, but try harder to fake something reasonable.

Test Plan

Used "View as Document Type..." on Jupyter notebooks, was given "Jupyter" and "Source" as options.

Event Timeline

  • Also restrict the list for changes with no candidate engines.
This revision was not accepted when it landed; it landed in state Needs Review.May 12 2020, 9:25 PM
This revision was automatically updated to reflect the committed changes.