Page MenuHomePhabricator

Make "View" from inline comment previews correctly jump to "isEditing" inlines
ClosedPublic

Authored by epriestley on May 8 2020, 2:51 PM.
Tags
None
Referenced Files
F13177614: D21237.id50577.diff
Wed, May 8, 7:50 PM
Unknown Object (File)
Tue, May 7, 10:00 AM
Unknown Object (File)
Fri, May 3, 9:59 AM
Unknown Object (File)
Thu, Apr 25, 3:23 AM
Unknown Object (File)
Wed, Apr 17, 5:38 PM
Unknown Object (File)
Apr 11 2024, 10:45 AM
Unknown Object (File)
Apr 8 2024, 1:34 PM
Unknown Object (File)
Mar 21 2024, 10:57 AM
Subscribers
None

Details

Summary

Ref T13513. Currently, clicking "View" from the inline comment preview (below the "add comment" area at the bottom of the page) only works if the inline isn't being edited.

Update this behavior so it works on inlines in either "Viewing" or "Editing" states.

Test Plan
  • Clicked "View" on a normal inline, got jumped/selected.
  • Clicked "View" on an editing inline, got jumped/selected.

Diff Detail

Repository
rP Phabricator
Branch
inline3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24391
Build 33605: Run Core Tests
Build 33604: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 8 2020, 3:52 PM
This revision was automatically updated to reflect the committed changes.