Page MenuHomePhabricator

Make "View" from inline comment previews correctly jump to "isEditing" inlines
ClosedPublic

Authored by epriestley on Fri, May 8, 2:51 PM.

Details

Summary

Ref T13513. Currently, clicking "View" from the inline comment preview (below the "add comment" area at the bottom of the page) only works if the inline isn't being edited.

Update this behavior so it works on inlines in either "Viewing" or "Editing" states.

Test Plan
  • Clicked "View" on a normal inline, got jumped/selected.
  • Clicked "View" on an editing inline, got jumped/selected.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Fri, May 8, 2:51 PM
epriestley requested review of this revision.Fri, May 8, 2:52 PM
This revision was not accepted when it landed; it landed in state Needs Review.Fri, May 8, 3:52 PM
This revision was automatically updated to reflect the committed changes.