Page MenuHomePhabricator

Make "View" from inline comment previews correctly jump to "isEditing" inlines
ClosedPublic

Authored by epriestley on May 8 2020, 2:51 PM.
Tags
None
Referenced Files
F18112330: D21237.diff
Tue, Aug 12, 4:24 PM
F18105053: D21237.diff
Sun, Aug 10, 4:05 PM
F18104479: D21237.id50577.diff
Sun, Aug 10, 12:41 PM
F18104310: D21237.id50575.diff
Sun, Aug 10, 11:20 AM
F18101105: D21237.id.diff
Sat, Aug 9, 12:19 PM
F18086993: D21237.id50575.diff
Wed, Aug 6, 1:42 AM
F17948713: D21237.id.diff
Thu, Jul 31, 9:50 PM
F17925674: D21237.diff
Wed, Jul 30, 11:54 AM
Subscribers
None

Details

Summary

Ref T13513. Currently, clicking "View" from the inline comment preview (below the "add comment" area at the bottom of the page) only works if the inline isn't being edited.

Update this behavior so it works on inlines in either "Viewing" or "Editing" states.

Test Plan
  • Clicked "View" on a normal inline, got jumped/selected.
  • Clicked "View" on an editing inline, got jumped/selected.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 8 2020, 3:52 PM
This revision was automatically updated to reflect the committed changes.