Page MenuHomePhabricator

Make "View" from inline comment previews correctly jump to "isEditing" inlines
ClosedPublic

Authored by epriestley on May 8 2020, 2:51 PM.
Tags
None
Referenced Files
F15461355: D21237.id50577.diff
Tue, Apr 1, 7:45 AM
F15455451: D21237.id.diff
Sun, Mar 30, 12:29 AM
F15449764: D21237.diff
Fri, Mar 28, 12:05 PM
F15409922: D21237.diff
Wed, Mar 19, 5:57 AM
F15372135: D21237.id50577.diff
Wed, Mar 12, 1:24 PM
F15330694: D21237.diff
Fri, Mar 7, 7:55 AM
Unknown Object (File)
Feb 9 2025, 9:15 AM
Unknown Object (File)
Feb 9 2025, 9:15 AM
Subscribers
None

Details

Summary

Ref T13513. Currently, clicking "View" from the inline comment preview (below the "add comment" area at the bottom of the page) only works if the inline isn't being edited.

Update this behavior so it works on inlines in either "Viewing" or "Editing" states.

Test Plan
  • Clicked "View" on a normal inline, got jumped/selected.
  • Clicked "View" on an editing inline, got jumped/selected.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 8 2020, 3:52 PM
This revision was automatically updated to reflect the committed changes.