Page MenuHomePhabricator

Make "View" from inline comment previews correctly jump to "isEditing" inlines
ClosedPublic

Authored by epriestley on May 8 2020, 2:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 5:38 PM
Unknown Object (File)
Thu, Apr 11, 10:45 AM
Unknown Object (File)
Mon, Apr 8, 1:34 PM
Unknown Object (File)
Thu, Mar 21, 10:57 AM
Unknown Object (File)
Feb 24 2024, 8:33 AM
Unknown Object (File)
Dec 27 2023, 1:24 PM
Unknown Object (File)
Dec 26 2023, 11:55 PM
Unknown Object (File)
Dec 26 2023, 6:43 PM
Subscribers
None

Details

Summary

Ref T13513. Currently, clicking "View" from the inline comment preview (below the "add comment" area at the bottom of the page) only works if the inline isn't being edited.

Update this behavior so it works on inlines in either "Viewing" or "Editing" states.

Test Plan
  • Clicked "View" on a normal inline, got jumped/selected.
  • Clicked "View" on an editing inline, got jumped/selected.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 8 2020, 3:52 PM
This revision was automatically updated to reflect the committed changes.