Page MenuHomePhabricator
Differential D21232

Move the "Inline List" view to "DiffInlineCommentQuery"
ClosedPublic
Actions

Authored by epriestley on May 7 2020, 8:03 PM.
Tags
None
Referenced Files
F19060011: D21232.diff
Sat, Nov 29, 7:34 AM
F18988176: D21232.diff
Tue, Nov 18, 1:24 AM
F18822219: D21232.id.diff
Oct 23 2025, 5:02 AM
F18818925: D21232.diff
Oct 22 2025, 3:16 AM
F18744532: D21232.id.diff
Oct 3 2025, 3:21 AM
F18704809: D21232.diff
Sep 28 2025, 8:56 AM
F18686501: D21232.id.diff
Sep 26 2025, 12:41 PM
F18627234: D21232.id.diff
Sep 16 2025, 3:32 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13513: Make schema changes to inlines to prepare for new inline features
Commits
rP983d77848b4c: Move the "Inline List" view to "DiffInlineCommentQuery"
Summary

Ref T13513. Continue removing usage sites for the obsolete "DifferentialInlineCommentQuery".

Test Plan

Viewed the inline list in Differential, saw sensible inlines.

Diff Detail

Repository
rP Phabricator
Branch
iquery9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24373
Build 33581: Run Core Tests
Build 33580: arc lint + arc unit

Event Timeline

epriestley created this revision.May 7 2020, 8:03 PM
Harbormaster completed remote builds in B24373: Diff 50557.May 7 2020, 8:04 PM
epriestley requested review of this revision.May 7 2020, 8:04 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 7 2020, 11:07 PM
Closed by commit rP983d77848b4c: Move the "Inline List" view to "DiffInlineCommentQuery" (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP983d77848b4c: Move the "Inline List" view to "DiffInlineCommentQuery".

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
controller/
9 lines
diffusion/
controller/
3 lines
3 lines
infrastructure/
diff/
query/
26 lines

Diff 50557

View Options

src/applications/differential/controller/DifferentialRevisionInlinesController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionDiffController.php

Loading...
View Options

src/infrastructure/diff/query/PhabricatorDiffInlineCommentQuery.php

Loading...
Phabricator · Built by Phacility