Differential D21230

Replace remaining pseudo-query methods on AuditInlineComment
ClosedPublic
Actions

Authored by epriestley on May 7 2020, 7:28 PM.

Details

Reviewers: None
Maniphest Tasks: T13513: Make schema changes to inlines to prepare for new inline features
Commits: rP949b9163d006: Replace remaining pseudo-query methods on AuditInlineComment

Summary

Ref T13513. Another step closer to the light.

Test Plan

Created, edited, deleted, replied to, and submitted inline comments in Diffusion.

Diff Detail

Repository

rP Phabricator

Branch

iquery7

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24371
Build 33577: Run Core Tests
Build 33576: arc lint + arc unit

Event Timeline

epriestley created this revision.May 7 2020, 7:28 PM

Harbormaster completed remote builds in B24371: Diff 50555.May 7 2020, 7:30 PM

epriestley requested review of this revision.May 7 2020, 7:30 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 7 2020, 11:04 PM

Closed by commit rP949b9163d006: Replace remaining pseudo-query methods on AuditInlineComment (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP949b9163d006: Replace remaining pseudo-query methods on AuditInlineComment.

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

storage/

PhabricatorAuditInlineComment.php

43 lines

diffusion/

controller/

DiffusionInlineCommentController.php

24 lines

Diff 50555

View Options

src/applications/audit/storage/PhabricatorAuditInlineComment.php