Page MenuHomePhabricator
Differential D21229

Replace "loadDraftComments()" with a Query
ClosedPublic
Actions

Authored by epriestley on May 7 2020, 7:09 PM.
Tags
None
Referenced Files
F19061437: D21229.diff
Sat, Nov 29, 12:20 PM
F19022727: D21229.id.diff
Sun, Nov 23, 10:10 PM
F18815414: D21229.id.diff
Oct 21 2025, 2:05 AM
F18807933: D21229.diff
Oct 19 2025, 3:59 AM
F18776351: D21229.id50565.diff
Oct 10 2025, 9:50 PM
F18772118: D21229.id50554.diff
Oct 9 2025, 12:26 AM
F18666551: D21229.diff
Sep 24 2025, 7:48 AM
F18625809: D21229.id.diff
Sep 15 2025, 11:36 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13513: Make schema changes to inlines to prepare for new inline features
Commits
rP6c59db20a379: Replace "loadDraftComments()" with a Query
Summary

Ref T13513. Take another step toward coherent query pathways for inlines.

Test Plan
  • Created, previewed, and submitted inlines in Diffusion.
  • Got a (mostly) appropriate draft state.
  • Got proper comment peristence, preview behavior, and submission behavior.

Diff Detail

Repository
rP Phabricator
Branch
iquery6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24370
Build 33575: Run Core Tests
Build 33574: arc lint + arc unit

Event Timeline

epriestley created this revision.May 7 2020, 7:09 PM
Harbormaster completed remote builds in B24370: Diff 50554.May 7 2020, 7:10 PM
epriestley requested review of this revision.May 7 2020, 7:10 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 7 2020, 11:02 PM
Closed by commit rP6c59db20a379: Replace "loadDraftComments()" with a Query (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP6c59db20a379: Replace "loadDraftComments()" with a Query.

Revision Contents
Changeset List

PathSize
src/
applications/
audit/
storage/
21 lines
diffusion/
editor/
10 lines
engine/
9 lines

Diff 50554

View Options

src/applications/audit/storage/PhabricatorAuditInlineComment.php

Loading...
View Options

src/applications/diffusion/editor/DiffusionCommitEditEngine.php

Loading...
View Options

src/applications/diffusion/engine/DiffusionCommitDraftEngine.php

Loading...
Phabricator · Built by Phacility