Page MenuHomePhabricator
Differential D21229

Replace "loadDraftComments()" with a Query
ClosedPublic
Actions

Authored by epriestley on May 7 2020, 7:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 21, 10:33 AM
Unknown Object (File)
Fri, Jan 3, 4:58 AM
Unknown Object (File)
Tue, Dec 31, 9:46 PM
Unknown Object (File)
Dec 22 2024, 4:10 AM
Unknown Object (File)
Dec 11 2024, 6:21 AM
Unknown Object (File)
Dec 7 2024, 7:44 AM
Unknown Object (File)
Dec 6 2024, 11:19 PM
Unknown Object (File)
Dec 3 2024, 2:03 PM
View All 83 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13513: Make schema changes to inlines to prepare for new inline features
Commits
rP6c59db20a379: Replace "loadDraftComments()" with a Query
Summary

Ref T13513. Take another step toward coherent query pathways for inlines.

Test Plan
  • Created, previewed, and submitted inlines in Diffusion.
  • Got a (mostly) appropriate draft state.
  • Got proper comment peristence, preview behavior, and submission behavior.

Diff Detail

Repository
rP Phabricator
Branch
iquery6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24370
Build 33575: Run Core Tests
Build 33574: arc lint + arc unit

Event Timeline

epriestley created this revision.May 7 2020, 7:09 PM
Harbormaster completed remote builds in B24370: Diff 50554.May 7 2020, 7:10 PM
epriestley requested review of this revision.May 7 2020, 7:10 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 7 2020, 11:02 PM
Closed by commit rP6c59db20a379: Replace "loadDraftComments()" with a Query (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP6c59db20a379: Replace "loadDraftComments()" with a Query.

Revision Contents
Changeset List

PathSize
src/
applications/
audit/
storage/
21 lines
diffusion/
editor/
10 lines
engine/
9 lines

Diff 50554

View Options

src/applications/audit/storage/PhabricatorAuditInlineComment.php

Loading...
View Options

src/applications/diffusion/editor/DiffusionCommitEditEngine.php

Loading...
View Options

src/applications/diffusion/engine/DiffusionCommitDraftEngine.php

Loading...
Phabricator · Built by Phacility